Skip to content
This repository has been archived by the owner on Sep 28, 2023. It is now read-only.

Request: php #1

Closed
robdecker opened this issue Oct 19, 2017 · 2 comments
Closed

Request: php #1

robdecker opened this issue Oct 19, 2017 · 2 comments

Comments

@robdecker
Copy link

Love the package! Could you add php highlighting?

@gkemmey
Copy link
Owner

gkemmey commented Oct 19, 2017

Hmmm there's at least an attempt to support PHP:

https://github.com/gkemmey/jekyll-syntax-highlighting/blob/master/grammars/jekyll-syntax-highlighting.cson#L243-L259

I know we piggyback off how the language-gfm package handles this, and it doesn't appear to be working quite right there either (at least not for me quickly testing):

image

I'll try and take a closer look this weekend, see if I can figure out what's going on.

@gkemmey
Copy link
Owner

gkemmey commented Oct 24, 2017

Update: @robdecker here's as far as I've gotten so far: #2

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants