Merge pull request #657 from dongho-shin/dev/fix-attribute

fix mergeGeometries exception color attribute
gkjohnson · Jun 29, 2024 · f2082e7 · f2082e7
2 parents c474dd7 + 50151a1
commit f2082e7
Showing 1 changed file with 14 additions and 1 deletion.
diff --git a/src/core/utils/mergeGeometries.js b/src/core/utils/mergeGeometries.js
@@ -205,7 +205,20 @@ export function mergeGeometries( geometries, options = {}, targetGeometry = new
 			const attr = geometry.getAttribute( key );
  			if ( ! skip ) {
 
-				copyAttributeContents( attr, targetAttribute, offset );
+				if ( key === 'color' && targetAttribute.itemSize !== attr.itemSize ) {
+
+					//make sure the color attribute is aligned with itemSize 3 to 4
+					for ( let index = offset; index < attr.count; ++ index ) {
+
+						attr.setXYZW( index, targetAttribute.getX( index ), targetAttribute.getY( index ), targetAttribute.getZ( index ), 1.0 );
+
+					}
+
+				} else {
+
+					copyAttributeContents( attr, targetAttribute, offset );
+
+				}
 
 			}