-
-
Notifications
You must be signed in to change notification settings - Fork 257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SkinnedMesh acceleratedRaycast #547
Comments
Hello! Can you explain your use case? The BVH generated by computeBoundsTree is static with no bone transforms applied so it's never been intended to be used with SkinnedMesh. |
In our virtual world platform people can drop GLTF models into the world in realtime, including avatars. Before placing them in the world, every mesh calls This also included SkinnedMeshes since they extend Mesh. Now that ThreeJS has added a raycast method to SkinnedMesh, our code continues to work but whenever you look at a SkinnedMesh the performance tanks hard because it no longer inherits the accelerated raycast from three-mesh-bvh. |
@ashconnell you could as well do
since what you did will not produce correct result any way |
I'd be hesitant to imply this is supported at all since there are common cases where the result will not at all be correct such as when the bone skeleton is rotated 90 degrees from the original model pose or significantly offset. I'm happy to leave this open in case others have thoughts but I think for the moment this has to be an unsupported expert use case / workaround. |
In Three v0.152.0 they introduced a raycast method on SkinnedMesh (see: mrdoob/three.js#25791)
This causes it to no longer inherit the three-mesh-bvh accelerated raycast added to Mesh.
I changed my setup from:
To this:
And it seems to have fixed the slow raycasting issues I was having.
Does it make sense for this to be the new setup in the README?
If so, I will make a PR.
The text was updated successfully, but these errors were encountered: