Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert to a WebExtension #69

Closed
rik opened this issue Mar 3, 2013 · 12 comments
Closed

Convert to a WebExtension #69

rik opened this issue Mar 3, 2013 · 12 comments
Assignees

Comments

@rik
Copy link
Collaborator

rik commented Mar 3, 2013

I don't think anyone is using this with Chrome. I haven't tested in Chrome once and no one is pushing a build anywhere on the web.

Removing the Ominum abstraction will make debug easier and might also let us add features that go outside the page.

I'll let this bug open for a few weeks and if no one complains, I'll drop support.

@gkoberger
Copy link
Owner

I'm all for this. It currently doesn't even compile to Chrome; it's just "possible" it could.

The real reason for "omnium" had nothing to do with Chrome, actually. I started this about a year before Firefox 4 was released, and half the company was on 3.6 and the other half was on the really unstable Fx4 nightlies. I couldn't decide which to use, and I figured it wouldn't be too hard to write a wrapper for both.

Oh, and I thought it was stupid how bad the Jetpack SDK. It was confusing and overly complicated, and I wanted people to basically be able to throw a bunch of JS/CSS files into a directory and hit "compile". Although I gave up halfway through, and it ended up just being complicated in different ways :)

@cvan
Copy link
Collaborator

cvan commented Sep 30, 2014

👎 to this

I use Chrome daily. And I know quite a few other Chrome users (whose names I will protect) that also happen to use Bugzilla.

@rik
Copy link
Collaborator Author

rik commented Dec 27, 2014

@cvan Have you tried the project on Chrome? I don't mind keeping support for it but I can't commit to fix it if it's not working either.

@mnoorenberghe mnoorenberghe changed the title Consider dropping Chrome support Convert to a WebExtension Aug 16, 2016
@mnoorenberghe
Copy link
Collaborator

At this point I think it makes sense to convert to a WebExtension and then we get Chrome, Edge, and Opera support along with Firefox.

@cvan
Copy link
Collaborator

cvan commented Aug 17, 2016

👍 agreed 100%. takers?

@yfdyh000
Copy link

Working on https://github.com/yfdyh000/BugzillaJS/tree/WebExtension.
Is making options popup to make it works and debug in Google Chrome.

@yfdyh000
Copy link

I found a options popup may not be necessary, due to "Your extension's content scripts can directly access user data without the need for a background page." on https://developer.chrome.com/extensions/storage#type-StorageArea. And an Options (preferences) tab (page) may be better.

However, I did not find a way to debugging the content scripts broken in Google Chrome.

@mnoorenberghe
Copy link
Collaborator

@yfdyh000 I would very much prefer merging/reviewing small, focused commits so feel free to open pull requests

@yfdyh000
Copy link

@mnoorenberghe Feel free to take and improves them, I don't have the experience for perfection and publishing them.

@marsjaninzmarsa
Copy link

Any up?

@mnoorenberghe
Copy link
Collaborator

I just submitted v4.0.0 to AMO which is an embedded Web Extension so it can migrate settings from the add-on SDK.

Version 4.1.0 will be a plain web extension and compatible with Fx57.

@mnoorenberghe mnoorenberghe self-assigned this Nov 10, 2017
@mnoorenberghe
Copy link
Collaborator

mnoorenberghe commented Nov 14, 2017

  • Version 4.0.1 was approved this morning and is an embedded web extension to convert preferences to the web extension storage
  • Version 4.1.0 was just approved for users running 57+ as a regular web extension

Force an update check in the add-on manager (rather than re-install from AMO) if you want to get the updates in the correct order (mostly for users not yet running 57+)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants