Reorganized spaces for shapeless 1 and 2 #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make use of spaces feature of dbuild which allows us to build multiple versions of the same project. We build shapeless 1.2.4 which is dependency of spray. This allows us to get rid of the fork of spray. We also build shapeless 2 which is dependency of specs2 and spire. The specs2 and spire compile successfully. Spray is still failing with compilations errors saved here: https://gist.github.com/gkossakowski/10277880
|
@cunei: this fail with: https://jenkins-dbuild.typesafe.com:8499/job/Community-2.11.x-manual/13/consoleText It seems like publishing is broken with this new spaces setup. |
|
I thought I had tested it. I had a look at the log, and I suspect that something might be awry with dbuild and sbt 0.13.2 (you merged this diff on top of the merged-in PR scala#33). We will know for sure tonight, as the community build in master (sans this diff) will fail in that case. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request patches the shapeless-two-version so that all transitive dependencies are included.
Currently specs2 needs shapeless 2.x, and all the other projects that depend on shapeless also need specs, so there are no shapeless1.2.4-specific projects; an empty section is provided as an example.
This pull request relies on the fact that two incompatible versions of shapeless (1 and 2) will not be used together, and that spray will also use shapeless2. If the intent is using shapeless1 with spray, instead, your original hack will work ok as it will trim the transitive dependencies on shapeless2.
This pull request is provided as an example.