Improved exception handling for unexpected and malformed messages #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good! I'm not sure this fixes the problem 100% because some issues in #13 were related to invalid incoming notifications, not mastodon signalling, but it should plug at least one source of worker crash issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves exception handling in two ways.
Firstly, it cleans up the handling when logging into and sending messages via mastodon which should prevent this happening when mastodon times out.
Secondly, should some malformed message be delivered or some other area in the code where an unexpected exception slips though there is now a top level catch all exception handler in the job queue to prevent the (usually single) worker from dying.
I believe this fixes #13