Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Matrix capability integration #28

Merged
merged 1 commit into from Jun 18, 2022
Merged

Conversation

Kvaciral
Copy link
Contributor

@Kvaciral Kvaciral commented May 6, 2022

To support Matrix as an outlet for ghi we:

  • edited ghi/configuration.py to read, check and use the (optional) Matrix-settings from the .yml-config
  • created ghi/ghimatrix.py to facilitate creating credential-files, logging onto a Matrix server and sending messages to one or more rooms on it by using the matrix-nio module
  • changed some naming and matrix-specific things in most of the files
  • changed the README.md en .ghy.yml.example to include the new Matrix-support
  • created ghi/util.py to facilitate in a workaround for a Matrix-issue (Messages with < or > are not seen as valid HTML matrix-org/matrix-appservice-irc#1562)
  • added relevant exception-handlers

No changes to the config-file are necessary when using IRC.

It works quite well with ghi/server.py, haven't tested it with AWS though, but should work as well.

Closes #27

Co-authored-by: W. J. van der Laan laanwj@protonmail.com

@laanwj
Copy link
Contributor

laanwj commented May 6, 2022

We've been using this for #bitcoin-core-dev (and various others) notifications for a while. Messages pass through the Matrix→IRC bridge successfully and look the same as the IRC notifications did.

Can confirm this closes #27.

To support Matrix as an outlet for ghi we:
-edited ghi/configuration.py to read, check and use the (optional) Matrix-settings from the .yml
-created ghi/ghimatrix.py to facilitate creating credential-files, logging onto a Matrix server and sending messages to one or more rooms on it by using the matrix-nio module
-changed some naming and matrix-specific things in most of the files
-changed the README.md en .ghy.yml.example to include the new Matrix-support
-created ghi/util.py to facilitate in a workaround for a Matrix-issue (matrix-org/matrix-appservice-irc#1562)
-added relevant exception-handlers

No changes to the config-file are necessary when using IRC.

It works quite well with server.py, haven't tested it with AWS though, but should work as well.

Closes gkrizek#27

Co-authored-by: W. J. van der Laan <laanwj@protonmail.com>
Copy link
Owner

@gkrizek gkrizek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll be honest, I don't use or work on this much anymore so you two probably have more knowledge and use than me. So if this is working for you I'm a +1 and happy to merge.

@gkrizek gkrizek merged commit 4620200 into gkrizek:master Jun 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Matrix backend
3 participants