Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contexts can come from other texts other than the token #4

Closed
gkunter opened this issue Apr 24, 2015 · 2 comments
Closed

Contexts can come from other texts other than the token #4

gkunter opened this issue Apr 24, 2015 · 2 comments

Comments

@gkunter
Copy link
Owner

gkunter commented Apr 24, 2015

Originally reported by: gkunter (Bitbucket: gkunter, GitHub: gkunter)


ISSUE:
Currently, Corpus.get_context() ignores whether the words within the context span are also from the same text as the query match. For example, a match that is the last token of one text will be printed with the first words of the next text as the right context;

SOLUTION:
Change the logic of get_context() so that start and end take the beginning and end into consideration.


@gkunter
Copy link
Owner Author

gkunter commented May 13, 2015

Original comment by gkunter (Bitbucket: gkunter, GitHub: gkunter):


FIXED:
The SQL query that handles context retrieval now includes a WHERE clause with source_ids.

@gkunter
Copy link
Owner Author

gkunter commented May 21, 2015

Original comment by gkunter (Bitbucket: gkunter, GitHub: gkunter):


Fix Issue #4: contexts do not extend beyond source bondaries.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant