CLI: When on Windows, print Windows path separator \ instead
#835
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Breaks the build |
|
Ah damn. It seems that I have used APIs available only in the newer Node versions, namely Question: Would you fix the test to include windows separator |
summivox
force-pushed
the
fix-cli-path-sep
branch
from
e45a7fb
to
4071764
Compare
|
@vendethiel : phew, now it passes even on node |
summivox
changed the title
/ even under Windows\ instead
vendethiel
added a commit
that referenced
this pull request
Feb 1, 2016
CLI: When on Windows, print Windows path separator `\` instead
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reason: consistency; passing test