New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI: When on Windows, print Windows path separator `\` instead #835

Merged
merged 1 commit into from Feb 1, 2016

Conversation

Projects
None yet
2 participants
@summivox
Contributor

summivox commented Jan 31, 2016

reason: consistency; passing test

@vendethiel

This comment has been minimized.

Contributor

vendethiel commented Jan 31, 2016

Breaks the build

@summivox

This comment has been minimized.

Contributor

summivox commented Jan 31, 2016

Ah damn. It seems that I have used APIs available only in the newer Node versions, namely path.posix.join.

Question: Would you fix the test to include windows separator \, or make CLI output / ?

@summivox

This comment has been minimized.

Contributor

summivox commented Feb 1, 2016

@vendethiel : phew, now it passes even on node v0.10.x. Shouldn't have taken new Node APIs for granted ;)

@summivox summivox changed the title from always use POSIX path sep `/` even under Windows to CLI: When on Windows, print Windows path separator `\` instead Feb 1, 2016

vendethiel added a commit that referenced this pull request Feb 1, 2016

Merge pull request #835 from summivox/fix-cli-path-sep
CLI: When on Windows, print Windows path separator `\` instead

@vendethiel vendethiel merged commit 9127329 into gkz:master Feb 1, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@vendethiel

This comment has been minimized.

Contributor

vendethiel commented Feb 1, 2016

Thanks!

@summivox summivox deleted the summivox:fix-cli-path-sep branch Feb 8, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment