New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix REPL tab completion #928

Merged
merged 2 commits into from Oct 5, 2016

Conversation

Projects
None yet
2 participants
@rhendric
Collaborator

rhendric commented Oct 4, 2016

Commit 40fae13 seems to have broken tab complete on chain expressions in
an attempt to make kebab-case tab completion work. This PR replaces
that implementation with a larger but more robust version that actually
works.

Additional features include supporting both kebab-case and camelCase
depending on what the user has already typed, and completion on less
JavaScript-friendly syntax patterns such as binding (.~) and
accessignment (.=).

Close #924
Close #157, incidentally.
See also #307 (can this be closed too?), #687, #732

rhendric added some commits Oct 4, 2016

pull repl from command into its own unit
This allows adding some tests to tab completion (which is currently a
little broken).
repl: fix tab completion
Commit 40fae13 seems to have broken tab complete on chain expressions in
an attempt to make kebab-case tab completion work. This commit replaces
that implementation with a larger but more robust version that actually
works.

Additional features include supporting both kebab-case and camelCase
depending on what the user has already typed, and completion on less
JavaScript-friendly syntax patterns such as binding (.~) and
accessignment (.=).
@gkz

This comment has been minimized.

Owner

gkz commented Oct 5, 2016

Thanks!

@gkz gkz merged commit 4564c0e into gkz:master Oct 5, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment