Fix REPL tab completion #928
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows adding some tests to tab completion (which is currently a little broken).
Commit 40fae13 seems to have broken tab complete on chain expressions in an attempt to make kebab-case tab completion work. This commit replaces that implementation with a larger but more robust version that actually works. Additional features include supporting both kebab-case and camelCase depending on what the user has already typed, and completion on less JavaScript-friendly syntax patterns such as binding (.~) and accessignment (.=).
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 40fae13 seems to have broken tab complete on chain expressions in
an attempt to make kebab-case tab completion work. This PR replaces
that implementation with a larger but more robust version that actually
works.
Additional features include supporting both kebab-case and camelCase
depending on what the user has already typed, and completion on less
JavaScript-friendly syntax patterns such as binding (.~) and
accessignment (.=).
Close #924
Close #157, incidentally.
See also #307 (can this be closed too?), #687, #732