improve: add callback as an optional argument to handle eval_js result #769
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tries to provide an optional argument
callback_name
to the functionfirenvim#eval_js
.The new signature of this function will be like the following:
In this way, we can handle the result of the javascript evaluation in the vim script.
Usages
output:
result "https://www.google.com"
output:
result {"userId":1,"id":1,"title":"delectus aut autem","completed":false}