Work around wrong gray color in windows console #136

glacejs · Jul 17, 2018 · 627fed6 · 627fed6
1 parent 1ada053
commit 627fed6
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 3 deletions.
diff --git a/lib/globals/test.js b/lib/globals/test.js
@@ -2,6 +2,7 @@
 
 const path = require("path");
 
+const _ = require("lodash");
 const U = require("glace-utils");
 const LOG = U.logger;
 
@@ -91,7 +92,7 @@ const baseTest = (names => {
         o.name = name;
 
         const skip = !!opts.skip;
-        const skipReason = U.defVal(opts.skip);
+        const skipReason = _.isString(opts.skip) ? opts.skip : null;
         o.retries = U.defVal(opts.retry, CONF.test.retries, 0);
         o.testOpts = {};
         o.testOpts.chunkRetry = U.defVal(opts.chunkRetry, CONF.test.chunkRetries, 0);

diff --git a/lib/reporter/stdout.js b/lib/reporter/stdout.js
@@ -84,8 +84,8 @@ var epilogue = () => {
     if (skippedTests.length !== 0) {
         msg = "skipped test" + (skippedTests.length === 1 ? "" : "s");
         stdout();
-        stdout((indent + "# " +
-                String(skippedTests.length).bold + " " + msg).gray);
+        // HACK https://github.com/glacejs/glace-core/issues/136
+        stdout(indent + "# ".gray + String(skippedTests.length).gray.bold + " " + msg.gray);
 
         for (var skip of skippedTests) {
             msg = `* '${skip.name}'`;

diff --git a/tests/unit/testGlobalsTest.js b/tests/unit/testGlobalsTest.js
@@ -155,6 +155,7 @@ suite("globals/test", () => {
             baseTest("my test", { skip: true }, () => {});
             expect(testFunc).to.not.be.called;
             expect(conf.test.cases[0].status).to.be.equal("skipped");
+            expect(conf.test.cases[0].rawInfo).to.be.empty;
         });
 
         chunk("skips with reason", () => {