Skip to content

Commit

Permalink
Add option to provide chrome options
Browse files Browse the repository at this point in the history
  • Loading branch information
schipiga committed Mar 26, 2018
1 parent de79915 commit a62aba0
Show file tree
Hide file tree
Showing 4 changed files with 47 additions and 1 deletion.
15 changes: 15 additions & 0 deletions lib/config.js
Expand Up @@ -14,6 +14,7 @@
*/

var expect = require("chai").expect;
var logfmt = require("logfmt");
var U = require("glace-utils");

var config = U.config;
Expand All @@ -36,6 +37,10 @@ config.chrome = U.defVal(config.chrome, {});
config.chrome.incognito = U.defVal(args.chromeIncognito, false);
config.chrome.headless = U.defVal(args.chromeHeadless, false);

if (args.chromeOptions) {
config.chrome.options = logfmt.parse(args.chromeOptions.replace(/'/g, "\""));
}

expect(["pc", "android", "ios"],
"Invalid `--platform` value").include(config.web.platform);
config.web.browser = U.defVal(args.browser);
Expand Down Expand Up @@ -76,6 +81,16 @@ if (config.web.platform === "pc") {
if (config.chrome.headless) {
desired.chromeOptions.args.push("headless");
}

if (config.chrome.options) {
for (var [k, v] of Object.entries(config.chrome.options)) {
if (v === true) {
desired.chromeOptions.args.push(k);
} else {
desired.chromeOptions.args.push(k + "=" + v);
}
}
}
};
} else {
config.web.isMobile = true;
Expand Down
5 changes: 5 additions & 0 deletions lib/pluginHelp.js
Expand Up @@ -78,5 +78,10 @@ module.exports = (args, d) => {
type: "boolean",
group: "Chrome:",
},
"chrome-options": {
describe: d("Provide space-separated chrome options with key=value style."),
type: "string",
group: "Chrome:",
},
});
};
27 changes: 26 additions & 1 deletion package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions package.json
Expand Up @@ -49,6 +49,7 @@
"chai": "^4.1.2",
"glace-utils": "^1.1.7",
"lodash": "^4.17.5",
"logfmt": "^1.2.0",
"selenium-standalone": "^6.13.0",
"weak": "^1.0.1",
"webdriverio": "^4.12.0"
Expand Down

0 comments on commit a62aba0

Please sign in to comment.