tenant support to v1.x #647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 1e04c95.
…se-version Display the Firebase version on the demo app
…ng-force-refresh Adding forceRefresh on getIdToken
* Upgrade some deps * Upgrade caniuse * Upgrade Prettier * Downgrade eslint to satisfy peerdeps * Minor upgrades for Next and Firebase deps * Upgrade firebase-admin * Upgrade firebase-admin in demo * Minor upgrade demo deps * Upgrade NFA version in demo * Upgrade more dependencies * Upgrade more demo dependencies * Revert "Upgrade more demo dependencies" This reverts commit 7da3e58. * Revert "Minor upgrade demo deps" This reverts commit 50f928e. * Minor upgrade Firebase * Pin typescript version (typing error with 4.4.4) and minor upgrade other types * Minor bump a few demo deps * Upgrade more demo deps * Upgrade some deps * Remove unused Codecov dependency
* Use Next 12 * Allow latest versions of Next and firebase-admin
* Use Next 12 * Allow latest versions of Next and firebase-admin * Upgrade Next to v12 * Update demo
* feat: fallback to applicationDefault credentials Co-Authored-By: Jesse Anderson <jeryanders@gmail.com> * chore: add test for firebaseAdminDefaultCredential * chore: update README with firebaseAdminDefaultCredential Co-Authored-By: Jesse Anderson <jeryanders@gmail.com> * chore: cleanup wording in README comments * fix: updates based on comments * chore: update error message in test Co-authored-by: Jesse Anderson <jeryanders@gmail.com>
* Upgrade most deps * Upgrade ESLint and Prettier and lint fix * Remove unneeded jsdom dep * Upgrade most example app deps * Upgrade example app lockfile deps * Upgrade lockfile deps
…adly-team#365) * fix: check for 'auth/argument-error' when verifying token * feat: upgrade firebase and firebase-admin * feat(gladly-team#174): handle additional errors from `verifyIdToken` * test(gladly-team#174): add tests coverage for new errors in `verifyIdToken` * feat: upgrade dependencies that have non breaking changes * feat: implement pr feedback * chore: upgrade dependencies * Rebuild lockfile * Include error if empty refreshToken * Add TODO Co-authored-by: Zino Hofmann <zino@hofmann.amsterdam> Co-authored-by: Zino Hofmann <zino@hofmann.amsterdam>
…team#368) * Add broken tests * Don't throw on token errors * Add assertion checks to tests * Add/modify comments in config validation * Move tests into describe block * Add error callbacks to config * Call error callbacks when we fail to refresh or verify the user's ID token * Add new config properties to types * Await error callback functions in case they need to perform something async * Lint fixes * Add tests * Update README.md
|
@juhanakristian is attempting to deploy a commit to the Gladly Team on Vercel. A member of the Team first needs to authorize it. |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## v1.x #647 +/- ##
==========================================
+ Coverage 98.05% 98.10% +0.04%
==========================================
Files 31 31
Lines 875 895 +20
Branches 257 272 +15
==========================================
+ Hits 858 878 +20
Misses 17 17
☔ View full report in Codecov by Sentry. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
kmjennison
requested changes
Jun 30, 2023
…xt-firebase-auth into feat/tenant-support-v1
|
The review issues have been fixed but I'll need to fix the issues from the TypeScript conversion |
|
Appreciate it! Sorry for blowing up your PR with all the changes! |
|
The conflicts have been resolved now but it looks like bundle size check is failing in the pipeline. Anything I should do about that? |
kmjennison
requested changes
Jul 7, 2023
kmjennison
reviewed
Jul 8, 2023
kmjennison
approved these changes
Jul 8, 2023
|
Thanks for making the last fix and merging the PR 👍 |
|
Of course! Thank you for your work on this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuing the work of @Twister42 and @HegarGarcia
Fixes some issues mentioned in #429 comments
The changes were originally made to
mainbut this PR is made against v1.x branch