Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix Typescript declaration file #658

Merged
merged 14 commits into from
Jul 3, 2023
Merged

Conversation

kmjennison
Copy link
Contributor

Fixes flaws introduced in #655 and #656

@vercel
Copy link

vercel bot commented Jul 3, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nfa-example ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 3, 2023 6:20pm

@codecov
Copy link

codecov bot commented Jul 3, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.01 ⚠️

Comparison is base (fca162d) 98.39% compared to head (d8b6628) 98.38%.

Additional details and impacted files
@@            Coverage Diff             @@
##             v1.x     #658      +/-   ##
==========================================
- Coverage   98.39%   98.38%   -0.01%     
==========================================
  Files          31       31              
  Lines         871      869       -2     
  Branches      257      257              
==========================================
- Hits          857      855       -2     
  Misses         14       14              
Impacted Files Coverage Δ
src/AuthAction.ts 100.00% <ø> (ø)
src/configTypes.ts 50.00% <ø> (ø)
src/redirects.ts 100.00% <ø> (ø)
src/firebaseAdmin.ts 94.11% <100.00%> (+0.05%) ⬆️
src/getUserFromCookies.ts 98.21% <100.00%> (ø)
src/index.server.ts 100.00% <100.00%> (ø)
src/index.ts 100.00% <100.00%> (ø)
src/initCommon.ts 100.00% <100.00%> (ø)
src/setAuthCookies.ts 100.00% <100.00%> (ø)
src/unsetAuthCookies.ts 100.00% <100.00%> (ø)
... and 3 more

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@kmjennison kmjennison merged commit 10e8fbc into v1.x Jul 3, 2023
7 checks passed
@kmjennison kmjennison deleted the kevin/improve-typings branch July 3, 2023 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant