feat(firebaseAdmin): fix to pass user custom user claims to createCustomToken #660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@velddev is attempting to deploy a commit to the Gladly Team on Vercel. A member of the Team first needs to authorize it. |
|
@kmjennison I noticed some of the codemods were running into test issues on my local machine, but the codemod itself works, just the spacing was off? Is this a known issue in the current branch? |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
kmjennison
approved these changes
Jul 3, 2023
|
@velddev Regarding codemod test errors, is it just linting problems or do the tests fail? I just did a refactor to TypeScript, so I wouldn't be surprised if I accidentally broke something with those JS files. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#654
#659some context: had to re-fork since my previous fork was stuck to takashi's repo and could not properly update. Hopefully this works now :)