Handle failure to verify refreshed token #679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the existing token is expired, and we refresh it successfully, we still need to call `veirfyIdToken` in order to get the `firebaseUser`, which is required by `createUser` below. Currently, if `verifyIdToken` with the newly refreshed token fails, the error handler is called, but the code passes through, calling `createUser` with a `token` but `firebaseUserAdminSDK: undefined`, which causes the following error: ``` Error: The "token" value can only be set if the "firebaseUserAdminSDK" property is defined. ``` In order to prevent this, we need to set `newTokenFailure = true` in case `verifyIdToken` fails with the newly refreshed token. FWIW this never happened to me in production, but happens quite often when developing with the Firebase emulators.
|
@valeriangalliat is attempting to deploy a commit to the Gladly Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
📢 Thoughts on this report? Let us know!. |
kmjennison
reviewed
Nov 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the existing token is expired, and we refresh it successfully, we still need to call
veirfyIdTokenin order to get thefirebaseUser, which is required bycreateUserbelow.Currently, if
verifyIdTokenwith the newly refreshed token fails, the error handler is called, but the code passes through, callingcreateUserwith atokenbutfirebaseUserAdminSDK: undefined, which causes the following error:In order to prevent this, we need to set
newTokenFailure = truein caseverifyIdTokenfails with the newly refreshed token.FWIW this never happened to me in production, but happens quite often when developing with the Firebase emulators.