Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Edit setAuthCookies parameter type #703

Merged
merged 1 commit into from
Dec 31, 2023
Merged

Conversation

kmjennison
Copy link
Contributor

Closes #684

Copy link

vercel bot commented Dec 31, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nfa-example ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 31, 2023 8:44pm

Copy link

codecov bot commented Dec 31, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2c6edfe) 98.08% compared to head (75682ab) 98.08%.

Additional details and impacted files
@@           Coverage Diff           @@
##             v1.x     #703   +/-   ##
=======================================
  Coverage   98.08%   98.08%           
=======================================
  Files          31       31           
  Lines         887      887           
  Branches      270      270           
=======================================
  Hits          870      870           
  Misses         17       17           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kmjennison kmjennison merged commit 8b311f3 into v1.x Dec 31, 2023
6 checks passed
@kmjennison kmjennison deleted the kevin/types-edit branch December 31, 2023 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve setAuthCookies types to no be necessary passing an empty object when not setting the token
1 participant