Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vertical progress bar moving horizontal on safari mobile #2

Closed
ssuess opened this issue May 17, 2015 · 15 comments
Closed

Vertical progress bar moving horizontal on safari mobile #2

ssuess opened this issue May 17, 2015 · 15 comments

Comments

@ssuess
Copy link

ssuess commented May 17, 2015

thanks for this plugin works great except in mobile safari (and mobile chrome for that matter) the vertical progress bar is moving horizontally (works great everywhere else on desktop browsers). Any suggestions?

@ssuess
Copy link
Author

ssuess commented May 17, 2015

just checked and same thing happens in your demo: http://www.jqueryscript.net/demo/Animated-Customizable-Progress-Meter-Plugin-For-jQuery-jQMeter/

@ssuess ssuess changed the title progress bar moving horizontal on safari mobile Vertical progress bar moving horizontal on safari mobile May 18, 2015
@glarios
Copy link
Owner

glarios commented May 19, 2015

Thanks for your feedback Stephen. I will look into a fix for this and let you know once it's resolved.

@ssuess
Copy link
Author

ssuess commented May 19, 2015

Thanks!

@pankajmehra009
Copy link

Is this issue solved yet , I have tried this on mobile browser and results are same.

Thanks

@ssuess
Copy link
Author

ssuess commented May 29, 2015

I haven't seen any code updates since I posted it, so I don't think it is solved yet, no. I have tried to look at the code myself to figure out what is causing it, but so far I am stumped as to why it only fails on mobile browsers.

@glarios
Copy link
Owner

glarios commented May 29, 2015

Sorry for the delay guys. I've been super busy. I just fixed the issue. I was using "orientation" as a variable name but that is a reserved name in mobile. Please use the newest release.

@glarios glarios closed this as completed May 29, 2015
@ssuess
Copy link
Author

ssuess commented May 29, 2015

Thanks for the update, but this new code actually breaks everywhere, on both mobile and desktop. The same thing that was happening only on mobile before is now happening on both mobile and desktop for me. Meaning: I have a vertical bar whose progress indicator is moving horizontally across it.

@glarios glarios reopened this May 29, 2015
@glarios
Copy link
Owner

glarios commented May 29, 2015

ssuess, can you provide a link? Did you update your plugin instatiation options to include meterOrientation instead of orientation?

@ssuess
Copy link
Author

ssuess commented May 29, 2015

no, I just replaced the min.js file...I'm sorry do I also need to make config changes?

@glarios
Copy link
Owner

glarios commented May 29, 2015

Yes, the "orientation" option needs to be "meterOrientation" now

@ssuess
Copy link
Author

ssuess commented May 29, 2015

Sorry let me try that and get back to you...

@glarios
Copy link
Owner

glarios commented May 29, 2015

So for example, it should be like this:

$('#jqmeter-container').jQMeter({meterOrientation:'vertical'});

@ssuess
Copy link
Author

ssuess commented May 29, 2015

fixed! Thanks!!!

@ssuess
Copy link
Author

ssuess commented May 29, 2015

but that should probably go in the docs, it still says "orientation" there...

@glarios
Copy link
Owner

glarios commented May 29, 2015

Yes, updating now.

@glarios glarios closed this as completed May 29, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants