Skip to content

Commit

Permalink
Issue GsDevKit#58: a bit of cleanup to get the 3.x tests to pass(?)
Browse files Browse the repository at this point in the history
  • Loading branch information
@dalehenrich
dalehenrich committed Dec 1, 2014
1 parent 7f47a99 commit c330b2e
Show file tree
Hide file tree
Showing 6 changed files with 5 additions and 6 deletions.
2 changes: 1 addition & 1 deletion repository/Zinc-GemStone-Server-Tools.package/ZnGemServer.class/instance/log.st
View file
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ log
ifFalse: [
"default logger snaps off continuations for errors and logs errors to
Transcript (gem server log file)"
logger := ZnTranscriptLogger new logger
logger := ZnTranscriptLogger new
filter: #'error';
yourself ].
log := ZnGemServerLogSupport new
Expand Down
2 changes: 1 addition & 1 deletion repository/Zinc-GemStone-Server-Tools.package/ZnGemServer.class/methodProperties.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,6 @@
"debugMode:" : "dkh 11/29/2014 08:44",
"delegate" : "dkh 11/29/2014 08:44",
"delegate:" : "dkh 11/29/2014 08:44",
"log" : "dkh 11/30/2014 19:17",
"log" : "dkh 11/30/2014 21:17",
"log:" : "dkh 11/30/2014 11:08",
"startServerOn:" : "dkh 11/30/2014 11:49" } }
2 changes: 1 addition & 1 deletion repository/Zinc-GemStone-Server-Tools.package/monticello.meta/version
View file
Original file line number Diff line number Diff line change
@@ -1 +1 @@
(name 'Zinc-GemStone-Server-Tools-dkh.6' message 'Issue #58: ZnWebSocketTests>>testEcho test passing ... in debugMode, use ZnObjectLogLogger ... practical to debug ZnGemServer using object log logging and continuations' id '2737e4b6-3600-49ac-ba57-ec8731159dab' date '11/30/2014' time '20:18:41' author 'dkh' ancestors ((name 'Zinc-GemStone-Server-Tools-dkh.5' message 'Issue #58: tweak recent changes ... and get back to getting tests to pass' id '43bffba2-7b67-49f9-b52c-721b80ee1b66' date '11/30/2014' time '11:54:09' author 'dkh' ancestors ((name 'Zinc-GemStone-Server-Tools-dkh.4' message 'Issue #58: a log can be specified for an instance of ZnGemServer. By default errors are logged to transcript and continuation commmited to object log.... ' id 'd017e51c-6b6a-404d-b07b-98b00853a012' date '11/30/2014' time '11:19:13' author 'dkh' ancestors ((name 'Zinc-GemStone-Server-Tools-dkh.3' message 'Issue #58:- always snap off continuation when an error event occurs- add some error handling a bit higher up the zn stack ... to catch application errors as well ... might be able to continue processing without passing error ... still passing at the moment... - ZnTranscriptLogger for all ZnGemServer guys ... might want to make this easier to customize' id 'c402419d-3976-4a02-ba31-be2670595768' date '11/30/2014' time '10:39:47' author 'dkh' ancestors ((name 'Zinc-GemStone-Server-Tools-dkh.2' message 'Issue #58: start using ZnGemServer based on work done for https://github.com/GsDevKit/gsApplicationTools/issues/2' id 'ac143ad6-d3f3-4abc-a318-dd2f3d0e8e64' date '11/29/2014' time '19:58:22' author 'dkh' ancestors ((name 'Zinc-GemStone-Server-Tools-dkh.1' message 'Issue #58: add dependency upon GsApplicationTools for Zinc-GemStone-Server-Tools, a new package which holds ZnServerStarter class needed by web socket tests ...' id '437b6f76-4bb6-4ea7-83b0-b5f93128158a' date '11/26/2014' time '13:39:44' author 'dkh' ancestors () stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())
(name 'Zinc-GemStone-Server-Tools-dkh.7' message 'Issue #58: a bit of cleanup to get the 3.x tests to pass(?)' id '479abb60-a604-4381-8746-8285d5265aa9' date '11/30/2014' time '21:19:18' author 'dkh' ancestors ((name 'Zinc-GemStone-Server-Tools-dkh.6' message 'Issue #58: ZnWebSocketTests>>testEcho test passing ... in debugMode, use ZnObjectLogLogger ... practical to debug ZnGemServer using object log logging and continuations' id '2737e4b6-3600-49ac-ba57-ec8731159dab' date '11/30/2014' time '20:18:41' author 'dkh' ancestors ((name 'Zinc-GemStone-Server-Tools-dkh.5' message 'Issue #58: tweak recent changes ... and get back to getting tests to pass' id '43bffba2-7b67-49f9-b52c-721b80ee1b66' date '11/30/2014' time '11:54:09' author 'dkh' ancestors ((name 'Zinc-GemStone-Server-Tools-dkh.4' message 'Issue #58: a log can be specified for an instance of ZnGemServer. By default errors are logged to transcript and continuation commmited to object log.... ' id 'd017e51c-6b6a-404d-b07b-98b00853a012' date '11/30/2014' time '11:19:13' author 'dkh' ancestors ((name 'Zinc-GemStone-Server-Tools-dkh.3' message 'Issue #58:- always snap off continuation when an error event occurs- add some error handling a bit higher up the zn stack ... to catch application errors as well ... might be able to continue processing without passing error ... still passing at the moment... - ZnTranscriptLogger for all ZnGemServer guys ... might want to make this easier to customize' id 'c402419d-3976-4a02-ba31-be2670595768' date '11/30/2014' time '10:39:47' author 'dkh' ancestors ((name 'Zinc-GemStone-Server-Tools-dkh.2' message 'Issue #58: start using ZnGemServer based on work done for https://github.com/GsDevKit/gsApplicationTools/issues/2' id 'ac143ad6-d3f3-4abc-a318-dd2f3d0e8e64' date '11/29/2014' time '19:58:22' author 'dkh' ancestors ((name 'Zinc-GemStone-Server-Tools-dkh.1' message 'Issue #58: add dependency upon GsApplicationTools for Zinc-GemStone-Server-Tools, a new package which holds ZnServerStarter class needed by web socket tests ...' id '437b6f76-4bb6-4ea7-83b0-b5f93128158a' date '11/26/2014' time '13:39:44' author 'dkh' ancestors () stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())
Expand Down
1 change: 0 additions & 1 deletion repository/Zinc-WebSocket-Tests.package/ZnWebSocketTests.class/instance/testEcho.st
View file
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ testEcho
| webSocket message gemServer |
ZnServer defaultServerClass initialize.
gemServer := (ZnGemServer register: 'ZnWebSocketTestEchoServer' on: #(1701))
debugMode: true;
delegate:
(ZnWebSocketDelegate map: 'ws-echo' to: ZnWebSocketEchoHandler new);
yourself.
Expand Down
2 changes: 1 addition & 1 deletion repository/Zinc-WebSocket-Tests.package/ZnWebSocketTests.class/methodProperties.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"setUp" : "dkh 11/30/2014 09:50",
"tearDown" : "dkh 11/30/2014 09:50",
"testChatroom" : "dkh 11/29/2014 19:55",
"testEcho" : "dkh 11/30/2014 20:14",
"testEcho" : "dkh 11/30/2014 21:18",
"testEchoSecureWebSocketsDotOrg" : "SebastianHeidbrink 11/02/2014 15:53",
"testEchoWebSocketsDotOrg" : "SebastianHeidbrink 11/02/2014 12:25",
"testStatus" : "dkh 11/30/2014 12:41" } }
2 changes: 1 addition & 1 deletion repository/Zinc-WebSocket-Tests.package/monticello.meta/version
View file
Original file line number Diff line number Diff line change
@@ -1 +1 @@
(name 'Zinc-WebSocket-Tests-dkh.14' message 'Issue #58: ZnWebSocketTests>>testEchoSecureWebSocketsDotOrg requires secure sockets (Zodiac) ... not supported in GemStone at the moment' id '6f531290-5cff-41f8-acdc-d55c679636a3' date '11/30/2014' time '20:24:57' author 'dkh' ancestors ((name 'Zinc-WebSocket-Tests-dkh.13' message 'Issue #58: ZnWebSocketTests>>testEcho test passing ... in debugMode, use ZnObjectLogLogger ... practical to debug ZnGemServer using object log logging and continuations' id '68b82d2d-0f98-4be1-a0ce-c5ce72d64718' date '11/30/2014' time '20:18:40' author 'dkh' ancestors ((name 'Zinc-WebSocket-Tests-dkh.12' message 'Issue #58: ZnWebSocketTests>>testStatus passing' id '24309e8c-7ec5-4872-b224-2f4b9ebd7825' date '11/30/2014' time '12:42:13' author 'dkh' ancestors ((name 'Zinc-WebSocket-Tests-dkh.11' message 'Issue #58:- always snap off continuation when an error event occurs- add some error handling a bit higher up the zn stack ... to catch application errors as well ... might be able to continue processing without passing error ... still passing at the moment... - ZnTranscriptLogger for all ZnGemServer guys ... might want to make this easier to customize' id 'd20e219a-a9f0-4fbc-9e04-a717fa870e0a' date '11/30/2014' time '10:39:47' author 'dkh' ancestors ((name 'Zinc-WebSocket-Tests-dkh.10' message 'Issue #58: start using ZnGemServer based on work done for https://github.com/GsDevKit/gsApplicationTools/issues/2' id '943bf05b-f825-4ad3-ac11-3e870f0b6da7' date '11/29/2014' time '19:58:22' author 'dkh' ancestors ((name 'Zinc-WebSocket-Tests-dkh.9' message 'add logging to ZnWebSocketFrameTests>>testReadingPing since it fails on Travis, but not locally...' id 'b36c3c39-1a2a-4c29-b9d1-00c993b4970d' date '11/20/2014' time '19:13:52' author 'dkh' ancestors ((name 'Zinc-WebSocket-Tests-SebastianHeidbrink.8' message 'Some websocket tests need to start an additional Gem ' id '2f9771e6-89a5-4ba8-b59f-a7f147c3a014' date '11/05/2014' time '14:25:28' author 'SebastianHeidbrink' ancestors ((name 'Zinc-WebSocket-Tests-SvenVanCaekenberghe.7' message 'added #testStatus' id '1d1c4570-f4a7-44f0-b22d-7aab5a808a64' date '09/07/2012' time '08:31:50' author 'SvenVanCaekenberghe' ancestors ((name 'Zinc-WebSocket-Tests-SvenVanCaekenberghe.6' message 'added #testChatroom;some cleanup' id '83cc094a-2d34-439e-bd14-6acd3bb3e846' date '09/07/2012' time '03:59:26' author 'SvenVanCaekenberghe' ancestors ((name 'Zinc-WebSocket-Tests-SvenVanCaekenberghe.5' message 'added ZnWebSocketDelegate class>>#map:to:' id '26845cfe-e494-4a40-b512-c428ce16dd9f' date '08/27/2012' time '09:01:42' author 'SvenVanCaekenberghe' ancestors ((name 'Zinc-WebSocket-Tests-SvenVanCaekenberghe.4' message 'tracking API changes' id '7c66d092-59ac-443b-b937-d7e39c6d8777' date '08/22/2012' time '02:57:43' author 'SvenVanCaekenberghe' ancestors ((name 'Zinc-WebSocket-Tests-SvenVanCaekenberghe.3' message 'added frame writing tests;added a key handshake test' id '8a26d0be-a05c-459b-b8bd-75cd9d59f1e2' date '08/22/2012' time '12:29:52' author 'SvenVanCaekenberghe' ancestors ((name 'Zinc-WebSocket-Tests-SvenVanCaekenberghe.2' message 'added more ZnWebSocketFrameTests;added ZnWebSocketTests>>#testEchoSecureWebSocketsDotOrg testing a secure (wss) client' id '887571c4-7f65-4cfc-a85f-7b7cc0b0773c' date '08/22/2012' time '11:18:14' author 'SvenVanCaekenberghe' ancestors ((name 'Zinc-WebSocket-Tests-SvenVanCaekenberghe.1' message 'added first couple of tests' id 'c488f09e-4948-4167-889d-d7ff344172b7' date '08/21/2012' time '10:42:32' author 'SvenVanCaekenberghe' ancestors () stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())
(name 'Zinc-WebSocket-Tests-dkh.15' message 'Issue #58: a bit of cleanup to get the 3.x tests to pass(?)' id 'a74b9e2e-7da7-4d95-ae3f-687ee0a4d207' date '11/30/2014' time '21:19:17' author 'dkh' ancestors ((name 'Zinc-WebSocket-Tests-dkh.14' message 'Issue #58: ZnWebSocketTests>>testEchoSecureWebSocketsDotOrg requires secure sockets (Zodiac) ... not supported in GemStone at the moment' id '6f531290-5cff-41f8-acdc-d55c679636a3' date '11/30/2014' time '20:24:57' author 'dkh' ancestors ((name 'Zinc-WebSocket-Tests-dkh.13' message 'Issue #58: ZnWebSocketTests>>testEcho test passing ... in debugMode, use ZnObjectLogLogger ... practical to debug ZnGemServer using object log logging and continuations' id '68b82d2d-0f98-4be1-a0ce-c5ce72d64718' date '11/30/2014' time '20:18:40' author 'dkh' ancestors ((name 'Zinc-WebSocket-Tests-dkh.12' message 'Issue #58: ZnWebSocketTests>>testStatus passing' id '24309e8c-7ec5-4872-b224-2f4b9ebd7825' date '11/30/2014' time '12:42:13' author 'dkh' ancestors ((name 'Zinc-WebSocket-Tests-dkh.11' message 'Issue #58:- always snap off continuation when an error event occurs- add some error handling a bit higher up the zn stack ... to catch application errors as well ... might be able to continue processing without passing error ... still passing at the moment... - ZnTranscriptLogger for all ZnGemServer guys ... might want to make this easier to customize' id 'd20e219a-a9f0-4fbc-9e04-a717fa870e0a' date '11/30/2014' time '10:39:47' author 'dkh' ancestors ((name 'Zinc-WebSocket-Tests-dkh.10' message 'Issue #58: start using ZnGemServer based on work done for https://github.com/GsDevKit/gsApplicationTools/issues/2' id '943bf05b-f825-4ad3-ac11-3e870f0b6da7' date '11/29/2014' time '19:58:22' author 'dkh' ancestors ((name 'Zinc-WebSocket-Tests-dkh.9' message 'add logging to ZnWebSocketFrameTests>>testReadingPing since it fails on Travis, but not locally...' id 'b36c3c39-1a2a-4c29-b9d1-00c993b4970d' date '11/20/2014' time '19:13:52' author 'dkh' ancestors ((name 'Zinc-WebSocket-Tests-SebastianHeidbrink.8' message 'Some websocket tests need to start an additional Gem ' id '2f9771e6-89a5-4ba8-b59f-a7f147c3a014' date '11/05/2014' time '14:25:28' author 'SebastianHeidbrink' ancestors ((name 'Zinc-WebSocket-Tests-SvenVanCaekenberghe.7' message 'added #testStatus' id '1d1c4570-f4a7-44f0-b22d-7aab5a808a64' date '09/07/2012' time '08:31:50' author 'SvenVanCaekenberghe' ancestors ((name 'Zinc-WebSocket-Tests-SvenVanCaekenberghe.6' message 'added #testChatroom;some cleanup' id '83cc094a-2d34-439e-bd14-6acd3bb3e846' date '09/07/2012' time '03:59:26' author 'SvenVanCaekenberghe' ancestors ((name 'Zinc-WebSocket-Tests-SvenVanCaekenberghe.5' message 'added ZnWebSocketDelegate class>>#map:to:' id '26845cfe-e494-4a40-b512-c428ce16dd9f' date '08/27/2012' time '09:01:42' author 'SvenVanCaekenberghe' ancestors ((name 'Zinc-WebSocket-Tests-SvenVanCaekenberghe.4' message 'tracking API changes' id '7c66d092-59ac-443b-b937-d7e39c6d8777' date '08/22/2012' time '02:57:43' author 'SvenVanCaekenberghe' ancestors ((name 'Zinc-WebSocket-Tests-SvenVanCaekenberghe.3' message 'added frame writing tests;added a key handshake test' id '8a26d0be-a05c-459b-b8bd-75cd9d59f1e2' date '08/22/2012' time '12:29:52' author 'SvenVanCaekenberghe' ancestors ((name 'Zinc-WebSocket-Tests-SvenVanCaekenberghe.2' message 'added more ZnWebSocketFrameTests;added ZnWebSocketTests>>#testEchoSecureWebSocketsDotOrg testing a secure (wss) client' id '887571c4-7f65-4cfc-a85f-7b7cc0b0773c' date '08/22/2012' time '11:18:14' author 'SvenVanCaekenberghe' ancestors ((name 'Zinc-WebSocket-Tests-SvenVanCaekenberghe.1' message 'added first couple of tests' id 'c488f09e-4948-4167-889d-d7ff344172b7' date '08/21/2012' time '10:42:32' author 'SvenVanCaekenberghe' ancestors () stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())
Expand Down

0 comments on commit c330b2e

Please sign in to comment.