Skip to content

Commit

Permalink
Issue GsDevKit#58: get rid of some of the undefined globals and sent …
Browse files Browse the repository at this point in the history 
…but not implemented methods
  • Loading branch information
@dalehenrich
dalehenrich committed Nov 26, 2014
1 parent b55918c commit f8df3b4
Show file tree
Hide file tree
Showing 5 changed files with 30 additions and 23 deletions.
16 changes: 11 additions & 5 deletions .../Zinc-WebSocket-Core.package/ZnWebSocketStatusHandler.class/instance/systemVersionInfo.st
View file
Original file line number Diff line number Diff line change
@@ -1,7 +1,13 @@
accessing
systemVersionInfo
^ String streamContents: [ :stream |
stream
print: SystemVersion current;
nextPutAll: ' - ';
nextPutAll: ZnConstants defaultServerString ]
| versionReport |
versionReport := System stoneVersionReport.
^ String
streamContents: [ :stream |
stream
print:
'GemStone ' , (versionReport at: 'gsRelease') , ' of '
, (versionReport at: 'gsBuildDate') , ' build '
, (versionReport at: 'gsBuildSerialNum');
nextPutAll: ' - ';
nextPutAll: ZnConstants defaultServerString ]
23 changes: 12 additions & 11 deletions repository/Zinc-WebSocket-Core.package/ZnWebSocketStatusHandler.class/instance/value..st
View file
Original file line number Diff line number Diff line change
@@ -1,14 +1,15 @@
accessing
value: webSocket
"I stream status messages to a WebSocket client, once every second
"I stream status messages to a WebSocket client, once every second
until ConnectionClosed or no longer isConnected"

[
webSocket log info: 'Started status streaming'.
[
webSocket sendMessage: self status.
1 second asDelay wait.
webSocket isConnected ] whileTrue ]
on: ConnectionClosed
do: [ webSocket log debug: 'Ignoring connection close' ].
webSocket log info: 'Stopping status streaming'

[
webSocket log info: 'Started status streaming'.
[
webSocket sendMessage: self status.
(Delay forSeconds: 1) wait.
webSocket isConnected ]
whileTrue ]
on: ConnectionClosed
do: [ webSocket log debug: 'Ignoring connection close' ].
webSocket log info: 'Stopping status streaming'
6 changes: 3 additions & 3 deletions repository/Zinc-WebSocket-Core.package/ZnWebSocketStatusHandler.class/instance/vmStats.st
View file
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
accessing
vmStats
^ [ SmalltalkImage current vm statisticsReport ]
on: MessageNotUnderstood
do: [ SmalltalkImage current vmStatisticsReportString ]
"augmentation needed"

^ SystemRepository fileSizeReport
6 changes: 3 additions & 3 deletions repository/Zinc-WebSocket-Core.package/ZnWebSocketStatusHandler.class/methodProperties.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,6 @@
"instance" : {
"processes" : "SvenVanCaekenberghe 9/7/2012 17:00",
"status" : "SvenVanCaekenberghe 9/7/2012 21:37",
"systemVersionInfo" : "SvenVanCaekenberghe 9/7/2012 16:38",
"value:" : "SvenVanCaekenberghe 10/13/2012 17:42",
"vmStats" : "SvenVanCaekenberghe 9/7/2012 16:23" } }
"systemVersionInfo" : "dkh 11/26/2014 10:44",
"value:" : "dkh 11/26/2014 10:43",
"vmStats" : "dkh 11/26/2014 10:42" } }
2 changes: 1 addition & 1 deletion repository/Zinc-WebSocket-Core.package/monticello.meta/version
View file
Original file line number Diff line number Diff line change
@@ -1 +1 @@
(name 'Zinc-WebSocket-Core-SebastianHeidbrink.26' message 'Gemstone 3.1.X port ' id '3c4311d8-69c2-47c8-95ae-ee61537df7aa' date '11/05/2014' time '19:48:05' author 'SebastianHeidbrink' ancestors ((name 'Zinc-WebSocket-Core-SvenVanCaekenberghe.25' message 'remove log instance variable from ZnWebSocketDelegate;use the new ZnCurrentServer value log instead' id 'f912c6ca-f295-4dec-9dc1-b47a877218e3' date '01/10/2013' time '03:59:18' author 'SvenVanCaekenberghe' ancestors ((name 'Zinc-WebSocket-Core-SvenVanCaekenberghe.24' message 'added fancier ZnWebSocketDelegate class>>#demoHtml front page to #installExamplesInServer:' id '07e7c6bc-cd48-4afa-a70f-33ef812c4c82' date '01/08/2013' time '01:54:14' author 'SvenVanCaekenberghe' ancestors ((name 'Zinc-WebSocket-Core-SvenVanCaekenberghe.23' message 'fixed client html/javascript code to use a ws:// uri relative to the page uri' id '26ce36c9-46c7-436e-bc3b-ba5e16ebd4c0' date '10/13/2012' time '08:56:13' author 'SvenVanCaekenberghe' ancestors ((name 'Zinc-WebSocket-Core-SvenVanCaekenberghe.22' message 'Added ZnWebSocketDelegate class>>#installExamplesInDefaultServer;Cleaned up logging:- added log support instance variable to ZnWebSocketDelegate and ZnWebSocket- refactored ZnWebSocketResponse with continuation block- added explicit ZnWebSocketDelegate>>#continuation' id 'b25d5a09-b334-4dcb-83b9-3893dbc53f32' date '10/13/2012' time '05:53:18' author 'SvenVanCaekenberghe' ancestors ((name 'Zinc-WebSocket-Core-SvenVanCaekenberghe.21' message 'improved robustness against #next returning nil on #atEnd by throwing ConnectionClosed in ZnWebSocketFrame>>#readFrom: (thx Jacob Wagner)' id '1a288db0-5969-4765-9d82-780e3425db96' date '09/17/2012' time '10:58:39' author 'SvenVanCaekenberghe' ancestors ((name 'Zinc-WebSocket-Core-SvenVanCaekenberghe.20' message 'fixed a typo' id '275ea0d1-e95a-468f-a209-9c322c2568a0' date '09/12/2012' time '09:16:16' author 'SvenVanCaekenberghe' ancestors ((name 'Zinc-WebSocket-Core-SvenVanCaekenberghe.19' message 'added some more comments' id 'e4ca1456-d8d8-4c3c-b4f2-9eaf066f4f20' date '09/12/2012' time '03:28:47' author 'SvenVanCaekenberghe' ancestors ((name 'Zinc-WebSocket-Core-SvenVanCaekenberghe.18' message 'extra documentation; re-categorizationadded ZnWebSocketDelegate class>>#handler:' id 'cf67dd6a-60a5-4c8b-a2ee-a078c318442c' date '09/11/2012' time '03:23:57' author 'SvenVanCaekenberghe' ancestors ((name 'Zinc-WebSocket-Core-SvenVanCaekenberghe.17' message 'add the use of a lock Mutex and #critical: sections to ZnWebSocketChatroomHandler;improved comments' id '803c38fc-9c49-45bc-9537-d813e58c8d75' date '09/10/2012' time '01:23:28' author 'SvenVanCaekenberghe' ancestors ((name 'Zinc-WebSocket-Core-SvenVanCaekenberghe.16' message 'html change' id '5b08ce9e-5075-42b3-9a3f-25c369c636be' date '09/07/2012' time '09:48:38' author 'SvenVanCaekenberghe' ancestors ((name 'Zinc-WebSocket-Core-SvenVanCaekenberghe.15' message 'minor code reformatting' id '484cbd72-d910-40c7-ac59-41e880ef5373' date '09/07/2012' time '09:38:50' author 'SvenVanCaekenberghe' ancestors ((name 'Zinc-WebSocket-Core-SvenVanCaekenberghe.14' message 'added ZnWebSocketStatusHandler example' id '34b9a4cc-24fc-48da-bfd0-fe87cbca88b4' date '09/07/2012' time '08:31:10' author 'SvenVanCaekenberghe' ancestors ((name 'Zinc-WebSocket-Core-SvenVanCaekenberghe.13' message 'moved the html generating methods around' id '857d3ddc-3254-48b3-818c-3621e55ebb98' date '09/07/2012' time '03:58:38' author 'SvenVanCaekenberghe' ancestors ((name 'Zinc-WebSocket-Core-SvenVanCaekenberghe.12' message 'Fixed a bug in ZnWebSocket>>#runWith: where non-existing nil messages where delivered whenever a socket timeout occurred;Added the ZnWebSocketChatroomHandler example;Made some core more robust;Added more comments' id 'c00cfb98-eba4-407b-901e-65168e6a1589' date '09/07/2012' time '02:42:28' author 'SvenVanCaekenberghe' ancestors ((name 'Zinc-WebSocket-Core-SvenVanCaekenberghe.11' message 'added some convencience ZnWebSocket class>>#startServerOn:[prefix:]do: methods;extended comments' id '46ad5865-182e-4ef1-a5ed-39423ddd646c' date '09/02/2012' time '08:56:40' author 'SvenVanCaekenberghe' ancestors ((name 'Zinc-WebSocket-Core-SvenVanCaekenberghe.10' message 'added ZnWebSocketDelegate class>>#map:to:' id '7a2e1f55-8ef9-472c-b334-20487a0caca2' date '08/27/2012' time '09:01:16' author 'SvenVanCaekenberghe' ancestors ((name 'Zinc-WebSocket-Core-SvenVanCaekenberghe.9' message 'refactoring of ZnWebSocket protocol code, introduction of ZnWebSocketClosed, and ZnWebSocket>>#runWith:' id 'b0a421a5-15b3-4982-bb63-f13dbc36ff8a' date '08/23/2012' time '12:05:13' author 'SvenVanCaekenberghe' ancestors ((name 'Zinc-WebSocket-Core-SvenVanCaekenberghe.8' message 'changed the semantics of ZnWebSocket>>#readFrame and #readMessage to throw ConnectionClosed when the other end closes;added prefix option to ZnWebSocketDelegate;refactored ZnWebSocketResponse>>#useConnection: to delegate to its handler;added new ZnWebSocketEchoHandler' id 'f48bf140-6ba9-4a88-817b-214f475675c0' date '08/22/2012' time '02:57:09' author 'SvenVanCaekenberghe' ancestors ((name 'Zinc-WebSocket-Core-SvenVanCaekenberghe.7' message 'debugging/extending ZnWebSocketFrame' id '559de1c2-4dfd-41a8-b4c7-122148388431' date '08/22/2012' time '11:16:31' author 'SvenVanCaekenberghe' ancestors ((name 'Zinc-WebSocket-Core-SvenVanCaekenberghe.6' message 'added ZnWebSocketFrame>>#isMasked' id '45287cf4-10ad-4a00-a353-d4c500d069a9' date '08/21/2012' time '10:44:32' author 'SvenVanCaekenberghe' ancestors ((name 'Zinc-WebSocket-Core-SvenVanCaekenberghe.5' message 'added multi-frame message sending' id '2b8b217e-7d2f-4592-8562-7c50bda1c090' date '08/21/2012' time '10:14:05' author 'SvenVanCaekenberghe' ancestors ((name 'Zinc-WebSocket-Core-SvenVanCaekenberghe.4' message 'added support for control protocol frames;refactoring' id '00fda542-814a-48a0-837b-fd091424a7f6' date '08/21/2012' time '09:30:44' author 'SvenVanCaekenberghe' ancestors ((name 'Zinc-WebSocket-Core-SvenVanCaekenberghe.3' message 'introduction of WebSocketFrame class;added role to WebSocket' id 'bc7296ef-0956-4e79-ab37-95d60f91dd61' date '08/21/2012' time '04:32:02' author 'SvenVanCaekenberghe' ancestors ((name 'Zinc-WebSocket-Core-SvenVanCaekenberghe.2' message 'first simple server code working' id '6fd1b1d2-7e22-4666-9707-c964698e6eae' date '08/21/2012' time '01:31:31' author 'SvenVanCaekenberghe' ancestors ((name 'Zinc-WebSocket-Core-SvenVanCaekenberghe.1' message 'very simple client code working' id 'db0800b5-d196-4f8a-819d-d08249174b8d' date '08/03/2012' time '03:57:47' author 'SvenVanCaekenberghe' ancestors () stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())
(name 'Zinc-WebSocket-Core-dkh.27' message 'Issue #58: get rid of some of the undefined globals and sent but not implemented methods' id '9830d3e0-2653-4cd9-a577-e14ec92d299d' date '11/26/2014' time '11:39:55' author 'dkh' ancestors ((name 'Zinc-WebSocket-Core-SebastianHeidbrink.26' message 'Gemstone 3.1.X port ' id '3c4311d8-69c2-47c8-95ae-ee61537df7aa' date '11/05/2014' time '19:48:05' author 'SebastianHeidbrink' ancestors ((name 'Zinc-WebSocket-Core-SvenVanCaekenberghe.25' message 'remove log instance variable from ZnWebSocketDelegate;use the new ZnCurrentServer value log instead' id 'f912c6ca-f295-4dec-9dc1-b47a877218e3' date '01/10/2013' time '03:59:18' author 'SvenVanCaekenberghe' ancestors ((name 'Zinc-WebSocket-Core-SvenVanCaekenberghe.24' message 'added fancier ZnWebSocketDelegate class>>#demoHtml front page to #installExamplesInServer:' id '07e7c6bc-cd48-4afa-a70f-33ef812c4c82' date '01/08/2013' time '01:54:14' author 'SvenVanCaekenberghe' ancestors ((name 'Zinc-WebSocket-Core-SvenVanCaekenberghe.23' message 'fixed client html/javascript code to use a ws:// uri relative to the page uri' id '26ce36c9-46c7-436e-bc3b-ba5e16ebd4c0' date '10/13/2012' time '08:56:13' author 'SvenVanCaekenberghe' ancestors ((name 'Zinc-WebSocket-Core-SvenVanCaekenberghe.22' message 'Added ZnWebSocketDelegate class>>#installExamplesInDefaultServer;Cleaned up logging:- added log support instance variable to ZnWebSocketDelegate and ZnWebSocket- refactored ZnWebSocketResponse with continuation block- added explicit ZnWebSocketDelegate>>#continuation' id 'b25d5a09-b334-4dcb-83b9-3893dbc53f32' date '10/13/2012' time '05:53:18' author 'SvenVanCaekenberghe' ancestors ((name 'Zinc-WebSocket-Core-SvenVanCaekenberghe.21' message 'improved robustness against #next returning nil on #atEnd by throwing ConnectionClosed in ZnWebSocketFrame>>#readFrom: (thx Jacob Wagner)' id '1a288db0-5969-4765-9d82-780e3425db96' date '09/17/2012' time '10:58:39' author 'SvenVanCaekenberghe' ancestors ((name 'Zinc-WebSocket-Core-SvenVanCaekenberghe.20' message 'fixed a typo' id '275ea0d1-e95a-468f-a209-9c322c2568a0' date '09/12/2012' time '09:16:16' author 'SvenVanCaekenberghe' ancestors ((name 'Zinc-WebSocket-Core-SvenVanCaekenberghe.19' message 'added some more comments' id 'e4ca1456-d8d8-4c3c-b4f2-9eaf066f4f20' date '09/12/2012' time '03:28:47' author 'SvenVanCaekenberghe' ancestors ((name 'Zinc-WebSocket-Core-SvenVanCaekenberghe.18' message 'extra documentation; re-categorizationadded ZnWebSocketDelegate class>>#handler:' id 'cf67dd6a-60a5-4c8b-a2ee-a078c318442c' date '09/11/2012' time '03:23:57' author 'SvenVanCaekenberghe' ancestors ((name 'Zinc-WebSocket-Core-SvenVanCaekenberghe.17' message 'add the use of a lock Mutex and #critical: sections to ZnWebSocketChatroomHandler;improved comments' id '803c38fc-9c49-45bc-9537-d813e58c8d75' date '09/10/2012' time '01:23:28' author 'SvenVanCaekenberghe' ancestors ((name 'Zinc-WebSocket-Core-SvenVanCaekenberghe.16' message 'html change' id '5b08ce9e-5075-42b3-9a3f-25c369c636be' date '09/07/2012' time '09:48:38' author 'SvenVanCaekenberghe' ancestors ((name 'Zinc-WebSocket-Core-SvenVanCaekenberghe.15' message 'minor code reformatting' id '484cbd72-d910-40c7-ac59-41e880ef5373' date '09/07/2012' time '09:38:50' author 'SvenVanCaekenberghe' ancestors ((name 'Zinc-WebSocket-Core-SvenVanCaekenberghe.14' message 'added ZnWebSocketStatusHandler example' id '34b9a4cc-24fc-48da-bfd0-fe87cbca88b4' date '09/07/2012' time '08:31:10' author 'SvenVanCaekenberghe' ancestors ((name 'Zinc-WebSocket-Core-SvenVanCaekenberghe.13' message 'moved the html generating methods around' id '857d3ddc-3254-48b3-818c-3621e55ebb98' date '09/07/2012' time '03:58:38' author 'SvenVanCaekenberghe' ancestors ((name 'Zinc-WebSocket-Core-SvenVanCaekenberghe.12' message 'Fixed a bug in ZnWebSocket>>#runWith: where non-existing nil messages where delivered whenever a socket timeout occurred;Added the ZnWebSocketChatroomHandler example;Made some core more robust;Added more comments' id 'c00cfb98-eba4-407b-901e-65168e6a1589' date '09/07/2012' time '02:42:28' author 'SvenVanCaekenberghe' ancestors ((name 'Zinc-WebSocket-Core-SvenVanCaekenberghe.11' message 'added some convencience ZnWebSocket class>>#startServerOn:[prefix:]do: methods;extended comments' id '46ad5865-182e-4ef1-a5ed-39423ddd646c' date '09/02/2012' time '08:56:40' author 'SvenVanCaekenberghe' ancestors ((name 'Zinc-WebSocket-Core-SvenVanCaekenberghe.10' message 'added ZnWebSocketDelegate class>>#map:to:' id '7a2e1f55-8ef9-472c-b334-20487a0caca2' date '08/27/2012' time '09:01:16' author 'SvenVanCaekenberghe' ancestors ((name 'Zinc-WebSocket-Core-SvenVanCaekenberghe.9' message 'refactoring of ZnWebSocket protocol code, introduction of ZnWebSocketClosed, and ZnWebSocket>>#runWith:' id 'b0a421a5-15b3-4982-bb63-f13dbc36ff8a' date '08/23/2012' time '12:05:13' author 'SvenVanCaekenberghe' ancestors ((name 'Zinc-WebSocket-Core-SvenVanCaekenberghe.8' message 'changed the semantics of ZnWebSocket>>#readFrame and #readMessage to throw ConnectionClosed when the other end closes;added prefix option to ZnWebSocketDelegate;refactored ZnWebSocketResponse>>#useConnection: to delegate to its handler;added new ZnWebSocketEchoHandler' id 'f48bf140-6ba9-4a88-817b-214f475675c0' date '08/22/2012' time '02:57:09' author 'SvenVanCaekenberghe' ancestors ((name 'Zinc-WebSocket-Core-SvenVanCaekenberghe.7' message 'debugging/extending ZnWebSocketFrame' id '559de1c2-4dfd-41a8-b4c7-122148388431' date '08/22/2012' time '11:16:31' author 'SvenVanCaekenberghe' ancestors ((name 'Zinc-WebSocket-Core-SvenVanCaekenberghe.6' message 'added ZnWebSocketFrame>>#isMasked' id '45287cf4-10ad-4a00-a353-d4c500d069a9' date '08/21/2012' time '10:44:32' author 'SvenVanCaekenberghe' ancestors ((name 'Zinc-WebSocket-Core-SvenVanCaekenberghe.5' message 'added multi-frame message sending' id '2b8b217e-7d2f-4592-8562-7c50bda1c090' date '08/21/2012' time '10:14:05' author 'SvenVanCaekenberghe' ancestors ((name 'Zinc-WebSocket-Core-SvenVanCaekenberghe.4' message 'added support for control protocol frames;refactoring' id '00fda542-814a-48a0-837b-fd091424a7f6' date '08/21/2012' time '09:30:44' author 'SvenVanCaekenberghe' ancestors ((name 'Zinc-WebSocket-Core-SvenVanCaekenberghe.3' message 'introduction of WebSocketFrame class;added role to WebSocket' id 'bc7296ef-0956-4e79-ab37-95d60f91dd61' date '08/21/2012' time '04:32:02' author 'SvenVanCaekenberghe' ancestors ((name 'Zinc-WebSocket-Core-SvenVanCaekenberghe.2' message 'first simple server code working' id '6fd1b1d2-7e22-4666-9707-c964698e6eae' date '08/21/2012' time '01:31:31' author 'SvenVanCaekenberghe' ancestors ((name 'Zinc-WebSocket-Core-SvenVanCaekenberghe.1' message 'very simple client code working' id 'db0800b5-d196-4f8a-819d-d08249174b8d' date '08/03/2012' time '03:57:47' author 'SvenVanCaekenberghe' ancestors () stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())
Expand Down

0 comments on commit f8df3b4

Please sign in to comment.