Bugfix UPCAReader #4
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Result is UPCA or EAN13. The old version returned an uninitialised Ref<Result> (at the EAN13 case) which let MultiFormatUPCEANReader::decodeRow (line 90) crash because a Result is assumed. The bugfix is technically oriented at the java version. Note: This error doesn't appear at normal tests because the MultiFormatUPCEANReader uses the EAN13 reader for UPC-A detection. The UPCAReader is only used if DecodeHints BarcodeFormat::UPC_A ist set.
http://blogs.msdn.com/b/vcblog/archive/2013/06/28/c-11-14-stl-features-fixes-and-breaking-changes-in-vs-2013.aspx --> You must #include <algorithm> when calling std::min() or std::max()
Old zxing issue 1795: https://code.google.com/p/zxing/issues/detail?id=1795
Old zxing issue: https://code.google.com/p/zxing/issues/detail?id=1796 This is really strange, because GenericGF has a GenericGFPoly reference and GenericGFPoly has a GenericGF reference the zxing:Ref "garbage collection" is not working properly. The bugfix replaced GenericGF zxing:Ref in GenericGFPoly with a normal reference. The same trick is used at ModulusPoly.h (pdf417\decoder\ec).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The maybeReturnResult function checks whether the Result is UPCA or EAN13. The old version returned an uninitialised Ref (at the EAN13 case) which let MultiFormatUPCEANReader::decodeRow (line 90)
crash because a Result is assumed.
The bugfix is technically oriented at the java version.
Note: This error doesn't appear at normal tests because the MultiFormatUPCEANReader
uses the EAN13 reader for UPC-A detection. The UPCAReader is only used if
DecodeHints BarcodeFormat::UPC_A ist set.