New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

internals: investigate destructuring #18

Closed

glathoud opened this issue Aug 22, 2019 · 1 comment

Owner

glathoud commented Aug 22, 2019

[this deals with the generated code, in particular the tail call elimination]

Frederico Kereki suggested to use destructuring when "updating" the variables, so that intermediary variables are not needed.

Paying attention to performance and IE11 compatibility (=no destructuring), the plan would look like this:

add a hidden option "destructuring", deactivated by default,
measure the performance with and without destructuring, at least in FF and Chrome
if positive results, make the option activated by default except in IE

glathoud added a commit that referenced this issue


          #18 prepared destructure implementation

b6d58cc

glathoud added a commit that referenced this issue


          #18 destructuring deactivated by default because it brings a slow-down

ef689a3

Owner Author

glathoud commented Sep 12, 2019

nope - slow down too big (about -33%) when using destructuring, so we'll keep it deactivated for now.

https://github.com/glathoud/fext#destructuring-18

glathoud closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment