Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support inline across files #7

Closed
glathoud opened this issue Feb 7, 2014 · 2 comments
Closed

support inline across files #7

glathoud opened this issue Feb 7, 2014 · 2 comments

Comments

@glathoud
Copy link
Owner

glathoud commented Feb 7, 2014

function declarations only + function name must be unique else error (we only parse and change the code, we do not execute it at this point).

About closures:

  • forbid inlining of a function from another file when the function body uses some external variables (closure).
  • permit closure when inlining a function within the same file as long as there is no ambiguity on the external variables. Else forbid (error).
@glathoud glathoud reopened this Feb 28, 2014
@glathoud
Copy link
Owner Author

todo: closure check in the various cases.

@glathoud
Copy link
Owner Author

Actually we would want NOT to forbid global access to "externals" (e.g. to some other tools) but only to forbid access to a locally bound variable.

glathoud pushed a commit that referenced this issue Feb 28, 2014
…ross files, re #7 forbid bound variable when inlining across files. Todo: #7 check the inlining intra-file: bound variables, if any, must be shared by the target scope and the scope of the source inlined body.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant