Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ci/fix build pipeline for v2 #256

Closed
wants to merge 3 commits into from

Conversation

aljoshare
Copy link

Unfortunately, PR #245 seems to have broken the push of docker images for v2 -> https://github.com/glauth/glauth/actions/runs/1907893346. This PR tries to fix it and contains the following changes:

  • Copy the working directory instead of the non-existent folder local/app
  • Don't change working directory to v2 in Github actions
  • Because of the change of the working directory, set the relative path (including v2) to the v2 Dockerfile when running docker build

Signed-off-by: Aljoscha Pörtner <aljoscha.poertner@posteo.de>
Signed-off-by: Aljoscha Pörtner <aljoscha.poertner@posteo.de>
Signed-off-by: Aljoscha Pörtner <aljoscha.poertner@posteo.de>
@aljoshare aljoshare force-pushed the ci/fix-build-pipeline-for-v2 branch from 56fb4af to 1421872 Compare April 8, 2022 14:14
@sonarcloud
Copy link

sonarcloud bot commented Apr 8, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@Fusion
Copy link
Collaborator

Fusion commented Apr 22, 2023

Thank you for the pull request.
Note that we are now pushing to Docker using the Makefile target releasedocker and we should remove this Github workflow as it creates confusion.

@Fusion Fusion closed this Apr 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants