Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Mac received event not fired when App is already ready #47

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

AlexanderArvidsson
Copy link

The use of will-finish-launching means apps that initialize deeplink when app is already ready will not work.
There could be multiple reasons for this, in my case we have to create the window no sooner than app ready, because we rely on header manipulation in session. Perhaps we can go around this somehow, however I feel this library should handle this case.

Is there any reason this library uses will-finish-launching over ready? If not, I think whenReady is best for this.
I haven't tried, but perhaps it's possible to exclude this completely, since registering event listeners before app is ready should be totally okay?

@Galkon
Copy link

Galkon commented Jun 6, 2024

Any chance this can be released? Would hate to fork it just to use an approved PR.

@AlexanderArvidsson
Copy link
Author

Any chance this can be released? Would hate to fork it just to use an approved PR.

While I have not personally tested it, glancing at the code at electron-app-universal-protocol-client, which is based on electron-deeplink, seems to use app.whenReady(), so it should work as a replacement.

@Galkon
Copy link

Galkon commented Jun 7, 2024

Any chance this can be released? Would hate to fork it just to use an approved PR.

While I have not personally tested it, glancing at the code at electron-app-universal-protocol-client, which is based on electron-deeplink, seems to use app.whenReady(), so it should work as a replacement.

Appreciate it, just found that library yesterday after visiting this thread.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants