Fix Mac received event not fired when App is already ready #47
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The use of
will-finish-launching
means apps that initialize deeplink when app is already ready will not work.There could be multiple reasons for this, in my case we have to create the window no sooner than app ready, because we rely on header manipulation in session. Perhaps we can go around this somehow, however I feel this library should handle this case.
Is there any reason this library uses
will-finish-launching
overready
? If not, I thinkwhenReady
is best for this.I haven't tried, but perhaps it's possible to exclude this completely, since registering event listeners before app is ready should be totally okay?