Don't output null for last element in list/array

[alexander-akait]

Input:

list(,$first, $second, $three, $fourth,) = $arr;

Contain null in arguments.

Babylon example: https://astexplorer.net/#/gist/6d37953c6b42f02a3ffe48b6101127c3/745b62f49d2c011d789e6d9754a4d705db5cdab0

I think it is unnecessary, because it is doesn't have sense for executing/parsing/printing/etc.

[ichiriac]

You're right about stripping null items from the end

[ichiriac]

fixed with this commit : a6519fd - released under 3.0.0-prerelease.4

[alexander-akait]

@ichiriac looks null still exists after upgrading to 3.0.0-prerelease.4 😕

[alexander-akait]

/cc @ichiriac friendly ping, still exists 😄

[ichiriac]

😀 sorry, i'll check this next week, this week-end i'm bussy, not at home. I'll keep you in tuch

[alexander-akait]

@ichiriac 👍 Thanks!

[ichiriac]

Hi,

I could strip them, but without node you may loose comments, here an example :

<?php
list($a, $b, /* arg3 */, /* arg 4 */) = [1,2,3,4];

It's better to introduce a Noop node that could bind at the right place the comment (could also be used on empty functions bodies in order to attach on it the comment

[alexander-akait]

👍

[ichiriac]

It's fixed & will be released soon

[alexander-akait]

@ichiriac maybe not right place, but just want put here with list problems for use prettier/plugin-php#854

[alexander-akait]

php7.3 was released very long time age and we sill doesn't support many features

[ichiriac]

ok, that was referenced under #345 & #346