regression in rc-6

[alexander-akait]

Input:

$var = $original instanceof self;

I know what i start helping with parser, but some issue is difficult for me and will be great if you help with some issues too.

[alexander-akait]

Also found bug with static. Need fix.

[ichiriac]

You are doing well and I really need help as I have no time during the day and little time the night and week-ends !

I'll focus on high-pri issues, if you want me to work on specific issues you can add the label. I'll start to work on comments this night and do a new RC release.

Many thanks for you help, without the project will never reach the end of a stable 3.0 release !

[alexander-akait]

We have a lot of bugs with #172 (marked as high priority), comments is also high, but we just print their ugly (i.e. don't break code), but for cast we break code in many cases 😞

[ichiriac]

ok, BTW you're right about static, it's an hard one to fix 🤞

[ichiriac]

so, here the read_class_name_reference is just an alias for read_variable as it does exactly what I need, but it's not yet finished.

I'll continue at home later ...

[ichiriac]

back, here the problem is that expr is recursive with expr_item, but here it's not, so I need to check the token and continue the expr parsing.

I dislike the way the parser work on this part as it's not really efficient and could be improved, I need a way to rewrite this part in the future.

[alexander-akait]

@ichiriac can you take care about this problem? Seems i don't have enough knowledge

[ichiriac]

it's fixed, you can add more tests if you see edge cases

[alexander-akait]

Thanks!