Fix 3108 #3226
Merged
Fix 3108 #3226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lpil
reviewed
Jun 1, 2024
|
Oh yes! I think it will be quite a big change because we don't have a warning emitter during parsing but it's totally doable, I'll change it |
|
Can we use just a vec? I think I want to remove the warning emitter now that we have an errors vec |
|
I'm not sure I understand how that would work, what do you mean by just using a vec? |
|
As in rather than pass in that emitter class pass in a vec and have it append to the vec. |
giacomocavalieri
force-pushed
the
fix-3108
branch
5 times, most recently
from
a655273
to
760f208
Compare
lpil
reviewed
Jun 20, 2024
giacomocavalieri
force-pushed
the
fix-3108
branch
from
56dc638
to
2a3fabf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #3108