fix excessive gleam.mjs generation
#3238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lpil
reviewed
Jun 4, 2024
This patch fixes excessive generation by checking if `modules` is empty. Two other possible solutions have been ruled out: - Checking for file existence may result in not updating outdated files - Comparing contents is slow closes gleam-lang#3178
ofekd
force-pushed
the
fix-gleammjs-generation
branch
from
d517764
to
4c1c6d6
Compare
|
All done, thanks for reviewing |
ofekd
pushed a commit
to ofekd/gleam
that referenced
this pull request
Jun 20, 2024
This patch fixes ecvession generation by checking files existence. An earlier attempt (gleam-lang#3238) had done this by checking for empty `modules`, noting in its commit message that file existence checks will cause old `gleam.mjs` to never be updated when a new version is available. I have since learned that that was incorrect, as new versions of `gleam` delete `build` folders created by previous versions. closes gleam-lang#3178
ofekd
pushed a commit
to ofekd/gleam
that referenced
this pull request
Jun 20, 2024
This patch fixes excessive generation by checking for file existence. An earlier attempt (gleam-lang#3238) had done this by checking for empty `modules`, noting in its commit message that file existence checks will cause old `gleam.mjs` to never be updated when a new version is available. I have since learned that that was incorrect, as new versions of `gleam` delete `build` folders created by previous versions. closes gleam-lang#3178
ofekd
pushed a commit
to ofekd/gleam
that referenced
this pull request
Jun 20, 2024
This patch fixes excessive generation by checking for file existence. An earlier attempt (gleam-lang#3238) had done this by checking for empty `modules`, noting in its commit message that file existence checks will cause old `gleam.mjs` to never be updated when a new version is available. I have since learned that that was incorrect, as new versions of `gleam` delete `build` folders created by previous versions. closes gleam-lang#3178
ofekd
pushed a commit
to ofekd/gleam
that referenced
this pull request
Jun 20, 2024
This patch fixes excessive generation by checking for file existence. An earlier attempt (gleam-lang#3238) had done this by checking for empty `modules`, noting in its commit message that file existence checks will cause old `gleam.mjs` to never be updated when a new version is available. I have since learned that that was incorrect, as new versions of `gleam` delete `build` folders created by previous versions. closes gleam-lang#3178
ofekd
pushed a commit
to ofekd/gleam
that referenced
this pull request
Jun 20, 2024
This patch fixes excessive generation by checking for file existence. An earlier attempt (gleam-lang#3238) had done this by checking for empty `modules`, noting in its commit message that file existence checks will cause old `gleam.mjs` to never be updated when a new version is available. I have since learned that that was incorrect, as new versions of `gleam` delete `build` folders created by previous versions. closes gleam-lang#3178
lpil
pushed a commit
that referenced
this pull request
Jun 22, 2024
This patch fixes excessive generation by checking for file existence. An earlier attempt (#3238) had done this by checking for empty `modules`, noting in its commit message that file existence checks will cause old `gleam.mjs` to never be updated when a new version is available. I have since learned that that was incorrect, as new versions of `gleam` delete `build` folders created by previous versions. closes #3178
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixes excessive generation by checking if
modulesis empty.Two other possible solutions have been ruled out:
closes #3178