Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show ignored fields on .. hover #3332

Merged
merged 5 commits into from
Jun 30, 2024
Merged

Show ignored fields on .. hover #3332

merged 5 commits into from
Jun 30, 2024

Conversation

giacomocavalieri
Copy link
Member

No description provided.

@giacomocavalieri giacomocavalieri marked this pull request as draft June 26, 2024 16:39
@giacomocavalieri giacomocavalieri marked this pull request as ready for review June 26, 2024 16:58
lpil
lpil reviewed Jun 30, 2024
View reviewed changes
Copy link
Member

@lpil lpil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! Left a small note

compiler-core/src/build.rs Outdated Show resolved Hide resolved
compiler-core/src/type_/pattern.rs Show resolved Hide resolved
lpil
lpil approved these changes Jun 30, 2024
View reviewed changes
Copy link
Member

@lpil lpil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful!!!

@lpil lpil merged commit 245cb47 into gleam-lang:main Jun 30, 2024
12 checks passed
@giacomocavalieri giacomocavalieri deleted the lsp-show-ignored-fields branch June 30, 2024 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpil lpil lpil approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@giacomocavalieri @lpil