-
-
Notifications
You must be signed in to change notification settings - Fork 696
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Partially fix #611 with Cow #743
Closed
Closed
Commits on Jul 22, 2020
-
Document: add basic support for Cow handling
The Text variant of Document now contains a Cow<str> instead of a String. This small modification triggered a lot of lifetime and type errors accross the codebase. This commits fixes these errors, in the most conservative way possible. Tests have been fixed too, so that they still compile (and pass). Next commits will focus on completely removing the usage of String in Document.
Configuration menu - View commit details
-
Copy full SHA for 0586173 - Browse repository at this point
Copy the full SHA 0586173View commit details -
Document: completely switch to Cow<str>
This commit removes every usage of String in Document, replacing it with the Cow<str> type. The work is not finished yet! A lot of clone still have to be removed. This will be the goal of the next few commits. Tests have been updated, and still pass.
Configuration menu - View commit details
-
Copy full SHA for e426160 - Browse repository at this point
Copy the full SHA e426160View commit details
Commits on Jul 23, 2020
-
Configuration menu - View commit details
-
Copy full SHA for c754bb7 - Browse repository at this point
Copy the full SHA c754bb7View commit details
Commits on Jul 24, 2020
-
Removed a clone call, fixed *most of* the code
The call to clone was removed in the implementation of Documentable for &str. Warning: the code currently does not compile. The compilation errors are due to pattern-matching. These errors *should* be fixed with the `butcher` crate, which *should* significantly reduce the amount of duplication generated by pattern-matching on enums wrapped in Cow.
Configuration menu - View commit details
-
Copy full SHA for 11fe0f4 - Browse repository at this point
Copy the full SHA 11fe0f4View commit details
Commits on Aug 5, 2020
-
Butcher will make Cow handling a bit less painfull, and will remove a lot of code duplication.
Configuration menu - View commit details
-
Copy full SHA for 507affe - Browse repository at this point
Copy the full SHA 507affeView commit details -
Configuration menu - View commit details
-
Copy full SHA for e094702 - Browse repository at this point
Copy the full SHA e094702View commit details -
Configuration menu - View commit details
-
Copy full SHA for af40e48 - Browse repository at this point
Copy the full SHA af40e48View commit details
Commits on Aug 12, 2020
-
Configuration menu - View commit details
-
Copy full SHA for c3522c0 - Browse repository at this point
Copy the full SHA c3522c0View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.