Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Partially fix #611 with Cow #743

Closed
wants to merge 8 commits into from
Closed

Partially fix #611 with Cow #743

wants to merge 8 commits into from

Commits on Jul 22, 2020

  1. Document: add basic support for Cow handling

    The Text variant of Document now contains a Cow<str> instead of a String. This
    small modification triggered a lot of lifetime and type errors accross the
    codebase.
    
    This commits fixes these errors, in the most conservative way possible. Tests
    have been fixed too, so that they still compile (and pass).
    
    Next commits will focus on completely removing the usage of String in Document.
    scrabsha committed Jul 22, 2020
    Configuration menu
    Copy the full SHA
    0586173 View commit details
    Browse the repository at this point in the history
  2. Document: completely switch to Cow<str>

    This commit removes every usage of String in Document, replacing it with the
    Cow<str> type.
    
    The work is not finished yet! A lot of clone still have to be removed. This will
    be the goal of the next few commits.
    
    Tests have been updated, and still pass.
    scrabsha committed Jul 22, 2020
    Configuration menu
    Copy the full SHA
    e426160 View commit details
    Browse the repository at this point in the history

Commits on Jul 23, 2020

  1. Configuration menu
    Copy the full SHA
    c754bb7 View commit details
    Browse the repository at this point in the history

Commits on Jul 24, 2020

  1. Removed a clone call, fixed *most of* the code

    The call to clone was removed in the implementation of Documentable for &str.
    
    Warning: the code currently does not compile. The compilation errors are due to
    pattern-matching. These errors *should* be fixed with the `butcher` crate,
    which *should* significantly reduce the amount of duplication generated by
    pattern-matching on enums wrapped in Cow.
    scrabsha committed Jul 24, 2020
    Configuration menu
    Copy the full SHA
    11fe0f4 View commit details
    Browse the repository at this point in the history

Commits on Aug 5, 2020

  1. Enter, butcher

    Butcher will make Cow handling a bit less painfull, and will remove a lot of code
    duplication.
    scrabsha committed Aug 5, 2020
    Configuration menu
    Copy the full SHA
    507affe View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    e094702 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    af40e48 View commit details
    Browse the repository at this point in the history

Commits on Aug 12, 2020

  1. Fix merge conflicts again

    This conflict comes from commit d4e11ea.
    scrabsha committed Aug 12, 2020
    Configuration menu
    Copy the full SHA
    c3522c0 View commit details
    Browse the repository at this point in the history