Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add warn if no fields are given in a record update #746

Merged
merged 4 commits into from
Aug 11, 2020
Merged

Add warn if no fields are given in a record update #746

merged 4 commits into from
Aug 11, 2020

Conversation

mrgleam
Copy link
Contributor

@mrgleam mrgleam commented Aug 6, 2020 •
edited
Loading

The PR add the warning if no fields are given in a record update for issue #739

Screen Shot 2563-08-07 at 00 22 14

@mrgleam
Copy link
Contributor Author

mrgleam commented Aug 7, 2020

fot Test compiler / build_compiler_macos

Screen Shot 2563-08-07 at 09 23 22

What am I missing?

@QuinnWilton
Copy link
Contributor

I don't see any reason this should be failing in CI. Have you tried repushing to trigger CI again and see whether the error goes away?

@mrgleam
Copy link
Contributor Author

mrgleam commented Aug 8, 2020

Try to trigger CI again.

@mrgleam mrgleam closed this Aug 8, 2020
@mrgleam mrgleam reopened this Aug 8, 2020
@mrgleam
Copy link
Contributor Author

mrgleam commented Aug 8, 2020

I re-open PR for trigger CI again. but I got same error in build_compiler_macos.

@QuinnWilton
Copy link
Contributor

@mrgleam I just noticed that the other open PR is failing for the same reason: #743

@mrgleam
Copy link
Contributor Author

mrgleam commented Aug 9, 2020

Thank you @QuinnWilton

@mrgleam
Copy link
Contributor Author

mrgleam commented Aug 9, 2020

I'm guessing.
It because dependencies cache is incomplete.
Because commit number 4c0e24a.
CI for build on MacOS passed and i see, the dependencies cache not found.
Screen Shot 2563-08-09 at 10 53 43

lpil
lpil approved these changes Aug 11, 2020
View reviewed changes
Copy link
Member

@lpil lpil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I'm rerunning CI, unsure why it failed. The OSX build does seem unreliable.

@lpil
Copy link
Member

lpil commented Aug 11, 2020

Still failing. I'm going to merge anyway

@lpil lpil merged commit 95c1fc8 into gleam-lang:main Aug 11, 2020
@mrgleam mrgleam deleted the issue-739 branch August 13, 2020 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpil lpil lpil approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mrgleam @QuinnWilton @lpil