Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interactive coding editor formatting issues #112

Closed
simon-curtis opened this issue Jun 5, 2024 · 1 comment · Fixed by #116
Closed

Interactive coding editor formatting issues #112

simon-curtis opened this issue Jun 5, 2024 · 1 comment · Fixed by #116

Comments

@simon-curtis
Copy link
Contributor

simon-curtis commented Jun 5, 2024

I'm jotting this down as I will fix it but am not at my PC

As per @lpil on the YouTube stream Gleam v1.2.0 is out now!!! at 27:13 the warning box has some min-height issue where it's causing the output box to show a scroll bar instead of filling the space.

Also, the editor and output on mobile seem to be collapsed and unusable.

Without testing it looks like the change was made here: fix hidden code editor

@simon-curtis
Copy link
Contributor Author

simon-curtis commented Jun 8, 2024

Warnings and errors now don't have 100% height, this prevents the false output scroll and allows multiple errors/warnings.

image

And, I have given the editor a min-height of 15rem to give a bit of space for mobile

image

@lpil lpil closed this as completed in #116 Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant