Differentiate data constructor names from type names #28
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per @patrickt's comment, I determined that it was finally time to differentiate types and constructor names, especially since I discovered that the
@constructor
highlight exists.While I could've fixed the highlighting by making the highlighting matching more specific, I figured it was time to stop lying and actually use a
(constructor_name)
node instead of(type_identifier)
in places where we're not actually referencing a type.Before
![before](https://user-images.githubusercontent.com/2058614/170101770-0905b3e2-85db-4c4a-b441-08c846d284b6.png)
After
![after](https://user-images.githubusercontent.com/2058614/170101493-8f346853-9dd6-48ef-925f-cd92fe3f64a4.png)
cc @the-mikedavis