Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'request' param to set_cookie examples #71

Merged
merged 1 commit into from May 4, 2024

Conversation

michaeljones
Copy link
Contributor

It seems to be necessary and it seems like the docs aren't in sync but I might be wrong.

It seems to be necessary and it seems like the docs aren't in sync but
I might be wrong.
Copy link
Collaborator

@lpil lpil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello! If you look closely you'll see that the request parameter is being piped in, so with this patch you'd be supplying the request as the first and the second argument, which is not valid.

@michaeljones
Copy link
Contributor Author

I think the repsonse parameter is being piped in but set_cookie wants both the response and the request as the first two arguments?

@michaeljones michaeljones requested a review from lpil May 4, 2024 13:11
Copy link
Collaborator

@lpil lpil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, you're right! I read this too fast.

Thanks!

@lpil lpil merged commit a824bd8 into gleam-wisp:main May 4, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants