Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added support bang methods #333

Merged
merged 2 commits into from Sep 16, 2019
Merged

Added support bang methods #333

merged 2 commits into from Sep 16, 2019

Conversation

dukaev
Copy link
Contributor

@dukaev dukaev commented Sep 16, 2019

@dukaev dukaev changed the title Added support band methods Added support bang methods Sep 16, 2019
@dukaev dukaev mentioned this pull request Sep 16, 2019
Closed
@glebm
Copy link
Owner

glebm commented Sep 16, 2019

You'll also need to add support to https://github.com/glebm/i18n-tasks/blob/master/lib/i18n/tasks/scanners/ruby_ast_scanner.rb

PatternScanner is only used for scanning non-Ruby files (e.g. ERB)

@glebm glebm merged commit 4fd3251 into glebm:master Sep 16, 2019
@glebm glebm added this to the v0.9.30 milestone Sep 16, 2019
@dukaev
Copy link
Contributor Author

dukaev commented Sep 16, 2019

How fast! 🔥

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
v0.9.30
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dukaev @glebm