-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename respond_to? method to respond_to_missing? to fix warning #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
denny@rocinante:~/code/denny/rails_email_preview$ git status
On branch master
Your branch is up-to-date with 'origin/master'.
nothing to commit, working tree clean
denny@rocinante:~/code/denny/rails_email_preview$ ruby -v
ruby 2.7.2p137 (2020-10-01 revision 5445e04352) [x86_64-linux]
denny@rocinante:~/code/denny/rails_email_preview$ rspec
........Capybara starting Puma...
* Version 5.2.2 , codename: Fettisdagsbulle
* Min threads: 0, max threads: 4
* Listening on http://127.0.0.1:7000
saving screenshot: list.png
.saving screenshot: list-de.png
.saving screenshot: show.png
....... exist app/mailer_previews
exist app/mailer_previews/auth_mailer_preview.rb
create app/mailer_previews/new_mailer_preview.rb
exist app/mailer_previews/newsletter_mailer_preview.rb
skip application_mailer
.
Finished in 1.47 seconds (files took 0.91953 seconds to load)
18 examples, 0 failures
denny@rocinante:~/code/denny/rails_email_preview$ rvm use 3
Using /home/denny/.rvm/gems/ruby-3.0.0
denny@rocinante:~/code/denny/rails_email_preview$ ruby -v
ruby 3.0.0p0 (2020-12-25 revision 95aff21468) [x86_64-linux]
denny@rocinante:~/code/denny/rails_email_preview$ rspec
......./home/denny/code/denny/rails_email_preview/lib/rails_email_preview/main_app_route_delegator.rb:11: warning: respond_to? is defined here
/home/denny/code/denny/rails_email_preview/lib/rails_email_preview/main_app_route_delegator.rb:11: warning: respond_to? is defined here
/home/denny/code/denny/rails_email_preview/lib/rails_email_preview/main_app_route_delegator.rb:11: warning: respond_to? is defined here
/home/denny/code/denny/rails_email_preview/lib/rails_email_preview/main_app_route_delegator.rb:11: warning: respond_to? is defined here
/home/denny/code/denny/rails_email_preview/lib/rails_email_preview/main_app_route_delegator.rb:11: warning: respond_to? is defined here
/home/denny/code/denny/rails_email_preview/lib/rails_email_preview/main_app_route_delegator.rb:11: warning: respond_to? is defined here
/home/denny/code/denny/rails_email_preview/lib/rails_email_preview/main_app_route_delegator.rb:11: warning: respond_to? is defined here
.Capybara starting Puma...
* Version 5.2.2 , codename: Fettisdagsbulle
* Min threads: 0, max threads: 4
* Listening on http://127.0.0.1:7000
/home/denny/code/denny/rails_email_preview/lib/rails_email_preview/main_app_route_delegator.rb:11: warning: respond_to? is defined here
/home/denny/code/denny/rails_email_preview/lib/rails_email_preview/main_app_route_delegator.rb:11: warning: respond_to? is defined here
/home/denny/code/denny/rails_email_preview/lib/rails_email_preview/main_app_route_delegator.rb:11: warning: respond_to? is defined here
/home/denny/code/denny/rails_email_preview/lib/rails_email_preview/main_app_route_delegator.rb:11: warning: respond_to? is defined here
/home/denny/code/denny/rails_email_preview/lib/rails_email_preview/main_app_route_delegator.rb:11: warning: respond_to? is defined here
/home/denny/code/denny/rails_email_preview/lib/rails_email_preview/main_app_route_delegator.rb:11: warning: respond_to? is defined here
/home/denny/code/denny/rails_email_preview/lib/rails_email_preview/main_app_route_delegator.rb:11: warning: respond_to? is defined here
/home/denny/code/denny/rails_email_preview/lib/rails_email_preview/main_app_route_delegator.rb:11: warning: respond_to? is defined here
/home/denny/code/denny/rails_email_preview/lib/rails_email_preview/main_app_route_delegator.rb:11: warning: respond_to? is defined here
saving screenshot: list.png
./home/denny/code/denny/rails_email_preview/lib/rails_email_preview/main_app_route_delegator.rb:11: warning: respond_to? is defined here
/home/denny/code/denny/rails_email_preview/lib/rails_email_preview/main_app_route_delegator.rb:11: warning: respond_to? is defined here
/home/denny/code/denny/rails_email_preview/lib/rails_email_preview/main_app_route_delegator.rb:11: warning: respond_to? is defined here
/home/denny/code/denny/rails_email_preview/lib/rails_email_preview/main_app_route_delegator.rb:11: warning: respond_to? is defined here
/home/denny/code/denny/rails_email_preview/lib/rails_email_preview/main_app_route_delegator.rb:11: warning: respond_to? is defined here
/home/denny/code/denny/rails_email_preview/lib/rails_email_preview/main_app_route_delegator.rb:11: warning: respond_to? is defined here
/home/denny/code/denny/rails_email_preview/lib/rails_email_preview/main_app_route_delegator.rb:11: warning: respond_to? is defined here
/home/denny/code/denny/rails_email_preview/lib/rails_email_preview/main_app_route_delegator.rb:11: warning: respond_to? is defined here
/home/denny/code/denny/rails_email_preview/lib/rails_email_preview/main_app_route_delegator.rb:11: warning: respond_to? is defined here
saving screenshot: list-de.png
./home/denny/code/denny/rails_email_preview/lib/rails_email_preview/main_app_route_delegator.rb:11: warning: respond_to? is defined here
/home/denny/code/denny/rails_email_preview/lib/rails_email_preview/main_app_route_delegator.rb:11: warning: respond_to? is defined here
/home/denny/code/denny/rails_email_preview/lib/rails_email_preview/main_app_route_delegator.rb:11: warning: respond_to? is defined here
/home/denny/code/denny/rails_email_preview/lib/rails_email_preview/main_app_route_delegator.rb:11: warning: respond_to? is defined here
/home/denny/code/denny/rails_email_preview/lib/rails_email_preview/main_app_route_delegator.rb:11: warning: respond_to? is defined here
/home/denny/code/denny/rails_email_preview/lib/rails_email_preview/main_app_route_delegator.rb:11: warning: respond_to? is defined here
/home/denny/code/denny/rails_email_preview/lib/rails_email_preview/main_app_route_delegator.rb:11: warning: respond_to? is defined here
/home/denny/code/denny/rails_email_preview/lib/rails_email_preview/main_app_route_delegator.rb:11: warning: respond_to? is defined here
/home/denny/code/denny/rails_email_preview/lib/rails_email_preview/main_app_route_delegator.rb:11: warning: respond_to? is defined here
/home/denny/code/denny/rails_email_preview/lib/rails_email_preview/main_app_route_delegator.rb:11: warning: respond_to? is defined here
saving screenshot: show.png
....... exist app/mailer_previews
skip application_mailer
exist app/mailer_previews/auth_mailer_preview.rb
create app/mailer_previews/new_mailer_preview.rb
exist app/mailer_previews/newsletter_mailer_preview.rb
.
Finished in 1.51 seconds (files took 1.09 seconds to load)
18 examples, 0 failures
denny@rocinante:~/code/denny/rails_email_preview$ git checkout fix/ruby-3.0-respond-to-warning
Switched to branch 'fix/ruby-3.0-respond-to-warning'
denny@rocinante:~/code/denny/rails_email_preview$ git diff master
diff --git a/lib/rails_email_preview/main_app_route_delegator.rb b/lib/rails_email_preview/main_app_route_delegator.rb
index 87b5e92..92e7f63 100644
--- a/lib/rails_email_preview/main_app_route_delegator.rb
+++ b/lib/rails_email_preview/main_app_route_delegator.rb
@@ -8,7 +8,7 @@ module RailsEmailPreview::MainAppRouteDelegator
end
end
- def respond_to?(method)
+ def respond_to_missing?(method)
super || main_app_route_method?(method)
end
denny@rocinante:~/code/denny/rails_email_preview$ rspec
........Capybara starting Puma...
* Version 5.2.2 , codename: Fettisdagsbulle
* Min threads: 0, max threads: 4
* Listening on http://127.0.0.1:7000
saving screenshot: list.png
.saving screenshot: list-de.png
.saving screenshot: show.png
....... exist app/mailer_previews
skip application_mailer
exist app/mailer_previews/auth_mailer_preview.rb
create app/mailer_previews/new_mailer_preview.rb
exist app/mailer_previews/newsletter_mailer_preview.rb
.
Finished in 1.62 seconds (files took 1.11 seconds to load)
18 examples, 0 failures
denny@rocinante:~/code/denny/rails_email_preview$ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The call to
respond_to?
in the route delegator started throwing copious warnings into my logs when I moved to Ruby 3.0.0; this change fixes it.