Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimized Feed Controllers #414

Merged
merged 4 commits into from
Jul 3, 2013
Merged

Optimized Feed Controllers #414

merged 4 commits into from
Jul 3, 2013

Conversation

sergeyklay
Copy link
Contributor

Optimized and removed duplicate code.

Now thanks to Controller_Feed_Base::_term and Controller_Feed_Base::_tag typical action is very clean and small :)

    /**
     * Get a list of pages with a specific term
     *
     * @since  1.1.0
     *
     * @uses  Controller_Feed_Base::_term
     */
    public function action_term()
    {
        parent::_term();
    }

Note: Controller_Feeds_Blog extends Controller_Feeds_Base and Controller_Feeds_Page extends Controller_Feeds_Base, not Controller_Feeds_Template

@sandeepone
Copy link
Member

Very good changes 👍

sandeepone added a commit that referenced this pull request Jul 3, 2013
Optimized Feed Controllers
@sandeepone sandeepone merged commit bcd7c01 into gleez:master Jul 3, 2013
@sergeyklay sergeyklay mentioned this pull request Jul 4, 2013
26 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants