Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Standardized Logging #334

Closed
gleitz opened this issue Feb 19, 2021 · 5 comments · Fixed by #381
Closed

Standardized Logging #334

gleitz opened this issue Feb 19, 2021 · 5 comments · Fixed by #381
Assignees
@gleitz

Comments

@gleitz
Copy link
Owner

gleitz commented Feb 19, 2021 •
edited

  • Standardize the way that errors are logged and reported to the user
  • Get rid of _print_err and use something standard
  • Verbosity level can then be controlled by command line flags
  • Explainability can perhaps be sent to standard error? Is this a common practice or should it go to standard out.
@gmelodie
Copy link
Collaborator

Related to #330

@gleitz gleitz mentioned this issue Feb 26, 2021
Closed
@atodorov
Copy link

@gleitz do you mind assigning this to MLH fellow @KimaruThagna

@gleitz
Copy link
Owner Author

gleitz commented Mar 26, 2021

Yes, please! Thanks @KimaruThagna

@KimaruThagna
Copy link

KimaruThagna commented Mar 30, 2021 •
edited

Taken it up. Will revert with ideas and work done @gleitz

@KimaruThagna KimaruThagna mentioned this issue Mar 30, 2021
Closed
gleitz added a commit that referenced this issue Apr 14, 2021
@gleitz
Add explainability and update logging
9817fe5 
Fixes #334
Fixes #330
gleitz added a commit that referenced this issue Apr 14, 2021
@gleitz
Add explainability and update logging
11692ef 
Fixes #334
Fixes #330
@gleitz gleitz mentioned this issue Apr 14, 2021
Merged
gleitz added a commit that referenced this issue Apr 14, 2021
@gleitz
Add explainability and update logging
11a0490 
Fixes #334
Fixes #330
@gleitz gleitz assigned gleitz and unassigned KimaruThagna Apr 14, 2021
@gleitz
Copy link
Owner Author

gleitz commented Apr 14, 2021

Proposed PR: #381

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gleitz gleitz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Explainability (v2) gleitz/howdoi
4 participants
@gleitz @atodorov @gmelodie @KimaruThagna