Fix gemspec #146
Merged
Fix gemspec #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoids the following warnings when building the gem: ``` NOTE: Gem::Specification#rubyforge_project= is deprecated with no replacement. It will be removed on or after 2019-12-01. Gem::Specification#rubyforge_project= called from ruby-graphviz.gemspec:23. NOTE: Gem::Specification#has_rdoc= is deprecated with no replacement. It will be removed on or after 2018-12-01. Gem::Specification#has_rdoc= called from ruby-graphviz.gemspec:24. ```
In 9437b34. Without these gemspec updates, the gem fails to be built with the following error: ``` ERROR: While executing gem ... (Gem::InvalidSpecificationException) ["AUTHORS.rdoc", "CHANGELOG.rdoc", "COPYING.rdoc", "README.rdoc"] are not files ```
|
Thanks for the merge @glejeune! Any chance of a release any time soon? I'm particularly interested in #144 because that would fix some errors we're getting in bundler when running our specs against ruby's master. |
|
Thanks for the release! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that the gem fails to be built on current master like this:
This PR fixes the gemspec so that it can be built again, and it also adds a few other tiny improvements to it.
Closes #141.