Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exit code is always 0 #11

Closed
just-boris opened this issue Sep 17, 2015 · 2 comments · Fixed by #12
Closed

Exit code is always 0 #11

just-boris opened this issue Sep 17, 2015 · 2 comments · Fixed by #12

Comments

@just-boris
Copy link
Contributor

Given a simple setup:

multi="progress=-" mocha --reporter mocha-multi

Always return zero exit code, even tests has been failed. Library versions:

   "mocha": "2.3.2",
   "mocha-multi": "0.7.1",

I guess it happens because mochajs/mocha#1059 already merged and some hacks doesn't necessary anymore. I could remove them by myself, but I am not sure, which parts of hacks actually still needed.
@just-boris
Copy link
Contributor Author

Also see my commit just-boris@a0756d7 as a possible fix

@glenjamin
Copy link
Owner

// Wait for streams, then exit seems redundant as a comment now you've extracted the function neatly.

Aside from that the change looks fine to me - can you make a pull request for it?

@just-boris just-boris mentioned this issue Sep 18, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor process exit interceptor
2 participants
@glenjamin @just-boris