Consolidate construction of API into one place #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yep, looks like a very clean solution to me. I like it. |
corbt
added a commit
that referenced
this pull request
Dec 30, 2015
Consolidate construction of API into one place
|
@glenjamin I see that you've given me push permission, so I've merged this. If you could still put an updated version on npm when you get a chance that would be great though. |
|
Yup, will do that when I next get to a computer. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@corbt Does this look sensible to you? It passes all the tests, but might be worth checking against real-world use?
Will cut a release afterwards if so.