Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add code coverage #35

Merged
merged 3 commits into from Oct 10, 2019
Merged

Add code coverage #35

merged 3 commits into from Oct 10, 2019

Conversation

glenjarvis
Copy link
Owner

No description provided.

Note that the .circleci config was not caching as expected. The cache
key was not bumped before changes were made and the "project/venv"
directory was being cached.

However, this was discovered when converting to workflows when adding code
coverage.
@glenjarvis glenjarvis self-assigned this Oct 10, 2019
@codecov-io
Copy link

codecov-io commented Oct 10, 2019

Codecov Report

Merging #35 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop      #35   +/-   ##
========================================
  Coverage    96.65%   96.65%           
========================================
  Files            5        5           
  Lines          269      269           
========================================
  Hits           260      260           
  Misses           9        9

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 80c6c00...2167516. Read the comment docs.

@glenjarvis glenjarvis merged commit c23ffb1 into develop Oct 10, 2019
@glenjarvis glenjarvis deleted the add_code_coverage_r0 branch October 10, 2019 22:32
@glenjarvis glenjarvis changed the title Add code coverage r0 Add code coverage Oct 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants