Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Collapsible to bypass onTransitionEnd if collapsible height is zero #178

Merged
merged 2 commits into from
Jan 29, 2021
Merged

Fix Collapsible to bypass onTransitionEnd if collapsible height is zero #178

merged 2 commits into from
Jan 29, 2021

Conversation

karltaylor
Copy link
Collaborator

Fixes #177

Issue

onTransitionEnd won't fire on a zero height collapsible, collapsible gets stuck because inTransition will be true

Fix

  • Check if the innerRef.scrollHeight is 0 to determine if we should set inTransition: true
  • Adds an example for this

@karltaylor karltaylor mentioned this pull request Jan 28, 2021
Closed
@karltaylor karltaylor merged commit 9d2e34e into develop Jan 29, 2021
@karltaylor karltaylor deleted the fix/177-open-close-with-zero-height branch January 29, 2021 16:11
@andpor andpor mentioned this pull request Nov 15, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glennflanagan glennflanagan Awaiting requested review from glennflanagan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Collapsible gets stuck when content is empty or zero-height
1 participant
@karltaylor