New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move babel plugin to dev deps #814

Merged

mmarkelov merged 1 commit into glennreyes:master from damianstasik:patch-1

Jul 31, 2023

Contributor

damianstasik commented Jul 31, 2023

This PR moves the @rollup/plugin-babel to the devDependencies, because it's used only during the build process. This will help with 2 issues:

Installation size will be a bit smaller if nothing else has @rollup/plugin-babel specified in their dependencies.
This will get rid of the warning during an installation due to a peer dependency (@babel/core).

warning "react-countup > @rollup/plugin-babel@6.0.3" has unmet peer dependency "@babel/core@^7.0.0".


          Move babel plugin to dev deps

1863d01

mmarkelov merged commit 7ca5365 into glennreyes:master

3 checks passed

Collaborator

mmarkelov commented Jul 31, 2023

@damianstasik good catch! Thank you for your PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment