Repair of CVE-2019-6129 #269 #293
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
halstead
pushed a commit
to openembedded/openembedded-core
that referenced
this pull request
Mar 25, 2020
Fix memory leak in png_create_info_struct. Upstream-Status: Submitted [pnggroup/libpng#293] CVE: CVE-2019-6129 Signed-off-by: Sakib Sajal <sakib.sajal@windriver.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
|
@ctruta @ctruta I have also verified this PR. When an abnormal situation is entered, it will enter branch and cause memory leak.This patch could solve this problem very well. Do you plan to merge this PR? |
|
@jbowler could you please review this fix as well? The commit does seem to solve the problem, but I am not sure it's the cleanest solution, unless you confirm that it is. |
|
NOTE: this is a duplicate of #269, I'll put comments in the original PR; this should be closed. |
|
A complete fix was provided by the original author, and integrated into the master branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Repair of CVE-2019-6129 #269