Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple labels #31

Merged
merged 3 commits into from
Feb 21, 2020
Merged

Multiple labels #31

merged 3 commits into from
Feb 21, 2020

Conversation

gleopoldo
Copy link
Owner

@gleopoldo gleopoldo commented Feb 21, 2020

What changed?

  1. I've fixed the multi-label syntax in cypher queries. The old syntax was using a comma separator for multiple labels, but cypher docs uses double colon instead

  2. The integration specs were causing a race condition in bolt_sips start-up when calling Bolt.Sips.start_link/0, which in turn performs a two step validation to check if Bolt.Sips.Router process exists and is alive. However, this can is error prone: if the Router process dies after the check-up, the start_link fails. So, in order to avoid integration specs setup_all block causing random failures, I've opted to force a retry whenever this occurs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant