Skip to content
This repository has been archived by the owner on Jul 19, 2022. It is now read-only.

players should be able to re-connect after disconnecting #5

Closed
andy5995 opened this issue Jan 14, 2018 · 3 comments
Closed

players should be able to re-connect after disconnecting #5

andy5995 opened this issue Jan 14, 2018 · 3 comments
Labels
enhancement New feature or request help wanted Extra attention is needed needs-testing priority: normal

Comments

@andy5995
Copy link
Contributor

If a player lags out, he should be able to re-connect to the game in-progress

@andy5995 andy5995 added enhancement New feature or request help wanted Extra attention is needed priority: normal labels Jan 14, 2018
@andy5995
Copy link
Contributor Author

@Jammyjamjamman told me the code to do this had been added but was disabled. If it works at all, I suggest enabling it so the bugs can be worked on.

If it's enabled, we'll have to figure out how to test locally if possible, and then document the process.

andy5995 added a commit that referenced this issue Jan 21, 2018
menu_state_custom_game.cpp:enable ability to join a running game

I assume this will help with #5
@andy5995
Copy link
Contributor Author

This enables some code that was put in place by the MG team

zetaglest/zetaglest-source@4e9ed10

I tested it. It allows for a player to rejoin after lagging out.

I tested it first by joining a running game

  • start client
  • host game
  • have network slots available when the game starts
  • start another client on the same computer
  • join LAN game

I then tested rejoining after a lag

  • while connected with the 2nd client, I cut my wifi off for a second
  • was then dropped by the running host
  • was able to rejoin the game

I don't know how stable the code is.. It hasn't been tested for any length of time yet, or under real-life conditions.

Oh, this is one problem.. one can only enable the "in-game" join when setting up a network game from the "custom game" menu, or from the "host game" button in the lobby.

@andy5995
Copy link
Contributor Author

re-joining works, but not reliably and has some other side effects.

So closing this ticket, and will create individual tickets as needed

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request help wanted Extra attention is needed needs-testing priority: normal
Projects
None yet
Development

No branches or pull requests

1 participant