Cast backed enum to its value when return type is a 'leaf' #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olvert
approved these changes
May 4, 2022
|
Should we maybe add a test for something that is "fully wrapped"?
Mostly to make sure that the recursion of Edit: We don't have support for "converting" lists of php-enums to |
emil-nasso
approved these changes
May 4, 2022
brother
approved these changes
May 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tldr; Eloquent models casting enums was catched by the
fieldFromArray(because ofArrayAccess) and the enum instance was returned instead of its value resulting in a "Expected a value of type "MyEnum" but received: instance of App\Enums\MyEnum" error.